On Thu, 2017-03-30 at 08:37 +0200, Jakub Jermář wrote: > Hi, > > On 03/30/2017 04:51 AM, Supragya Raj wrote: > > In the given patch, I have changed a few things as Jakub advised, > > changing uint32_t and uint64_t to int32_t and int64_t. > > I've just applied your patch in mainline,2586. Thanks for contributing this!
the patch looks wrong. all three instances are missing break statement. Thus the qualifier will always be 'PrintfQualifierShort'. The test won't catch this, because it only tests small difference that fits into the first two bytes (on LE machines). Has anyone run the test on a BE machine? Jan > > > P.S. I have uploaded the very initial GSoC proposal to docs.google.com > > <http://docs.google.com>. Link of same is pasted in the link box. I have > > set the edit mode to comments only. Should I change it to allow edits? > > No, we only need to be able to create comments. > > Regards, > Jakub > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/listinfo/helenos-devel
signature.asc
Description: This is a digitally signed message part
_______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
