Hi Jiri,

On 11/21/2017 10:32 PM, Jiri Svoboda wrote:
> your commit:
> 
> commit 2a72d9fbcffe5d34ff500bcdfb95b61bec9bac9d
> Author: Jakub Jermar <ja...@jermar.eu>
> Date:   Fri Nov 25 18:17:20 2016 +0100
> 
>     Consider serial devices input devices
> 
> makes the following change in uspace/srv/hid/intput/input.c:
> 
> @@ -554,9 +640,6 @@ static void kbd_add_legacy_devs(void)
>  #if defined(UARCH_sparc64) && defined(PROCESSOR_sun4v)
>         kbd_add_dev(&niagara_port, &stty_ctl);
>  #endif
> -#if defined(UARCH_sparc64) && defined(MACHINE_generic)
> -       kbd_add_dev(&ns16550_port, &sun_ctl);
> -#endif
>         /* Silence warning on abs32le about kbd_add_dev() being unused */
>         (void) kbd_add_dev;
>  }
> 
> This effectively removes the support for real keyboard on Sun Ultra
> workstations. Was this intentional? If so, why?

Yes, this was intentional. I removed this legacy initialization code in
favor of a DDF based one which uses serial console and can be used
together with ever-improving QEMU w/ OpenBIOS* (but broke keyboard
support on the real Sun workstations for the time being) even by people
who don't have access to a real-world Sun workstation.

I intend this regression in functionality to be rather temporary as it
should be possible to reimplement the lost functionality using DDF
drivers. We should however first discuss how to figure out which device
is the console. The boot argument solution is a bit clumsy and inflexible.

HTH,
Jakub

* In 2.11 QEMU will become even more similar to the real world Ultra 5
because it will feature two Simba PCI buses attached to the main PCI bus
using a PCI-to-PCI bridge.

_______________________________________________
HelenOS-devel mailing list
HelenOS-devel@lists.modry.cz
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to