Hi Jiří,
I removed the explicit inline specifiers for the helper
functions.
--
mc
Jiri Svoboda <jirik.svob...@seznam.cz> wrote:
> Hi Miroslav,
>
> looks good. I wouldn't think the encode_xx_ee() functions are strictly
> necessary, but if you'd like to have it this way, fine. I'd prefer if you
> didn't mark them as 'inline' as a matter of style, as it's superfluous - the
> compiler is smart enough to figure that out for itself. Otherwise LGTM.
>
> Cheers,
> Jiri
>
> ---------- Původní e-mail ----------
> Od: Miroslav Cimerman <m...@doas.su>
> Komu: HelenOS development mailing list <helenos-devel@lists.modry.cz>
> Datum: 12. 6. 2024 23:28:17
> Předmět: Re: [HelenOS-devel] GPT partition type UUID
>
>
>
> > Hi Jiri,
> >
> > I force pushed the changes on the current PR. What do you think?
> >
> > --
> > mc
> >
> >
> > Jiri Svoboda <jirik.svob...@seznam.cz> wrote:
> >
> > > Hi Miroslav,
> > >
> > > > Do you mean something like:
> > > >
> > > > #define _UUID_NODE_LEN 6
> > > >
> > > > typedef struct {
> > > > uint32_t time_low;
> > > > uint16_t time_mid;
> > > > uint16_t time_hi_and_version;
> > > > uint8_t clock_seq_hi_and_reserved;
> > > > uint8_t clock_seq_low;
> > > > uint8_t node[_UUID_NODE_LEN];
> > > > } uuid_t;
> > >
> > > Yeah, something like that would work. Alternatively, you could also
> > > represent node as uint16_t node_hi + uint32_t node_lo.
> > >
> > >
> > >
> > > Cheers,
> > >
> > > Jiri
> >
> > _______________________________________________
> > HelenOS-devel mailing list
> > HelenOS-devel@lists.modry.cz
> > http://lists.modry.cz/listinfo/helenos-devel
_______________________________________________
HelenOS-devel mailing list
HelenOS-devel@lists.modry.cz
http://lists.modry.cz/listinfo/helenos-devel
