On 31 October 2011 14:31, Robert Carleton <r...@rbcarleton.com> wrote:

> Suggest you move "body depth_search recurse" from failsafe.cf into
> update.cf, it is used in update.cf and not in failsafe.cf.
>
>
> body depth_search recurse(d) is defined in both failsafe.cf and
> cfengine_stdlib.cf.  The definition in failsafe.cf is just to provide the
> name when cfengine_stdlib.cf (COPBL) isn't loaded.  Loading the COPBL
> during failsafe conditions didn't feel right to me.
>

I didn't want you to load COPBL; as you say, that doesn't feel right for
failsafe.cf (too heavy, too much stuff you don't need for a lean failsafe
policy). I just pointed out that you use recurse in update.cf, but you
define it in failsafe.cf. It works fine, but I think it is more readable if
you define it in the same file as you use it. Moving it will make it
consistent with what you do with body perms system and body copy_from
mycopy; both of these are defined in update.cf..

This is of course a tiny issue, but may be important for a beginner.

- Erlend
_______________________________________________
Help-cfengine mailing list
Help-cfengine@cfengine.org
https://cfengine.org/mailman/listinfo/help-cfengine

Reply via email to