Here is another problem still not fixed in 2.1.18.

cfservd.c line 423:

while(VSYSNAME.nodename[i++] != '.')

This loop should be changed to terminate if a null byte (end of string)
is encountered.  It is running past the end of the array at runtime,
perhaps as a result of the StrStr call bug.

Now that I think about it, it seems as though the following test
is logically wrong:

if (StrStr(VSYSNAME.nodename,ToLowerStr(VDOMAIN)))

What if the nodename happens to be a substring of the domain,
but is not fully qualified?
-- 
Joe Buehler



_______________________________________________
Help-cfengine mailing list
Help-cfengine@gnu.org
http://lists.gnu.org/mailman/listinfo/help-cfengine

Reply via email to