Rutherther <[email protected]> writes: >> I think the 'v1.5.0rc1' tag should be for when that version of guix is >> made available. >> >> That is, I think the tag should have been on commit >> d339785a0fbd8f13930082a4fa7a73b6685630fd rather than >> 2d4ed08662714ea46cfe0b41ca195d1ef845fd1b -- compare info from >> 'git log --format=oneline': > > I don't think we can do that, then we would be saying the guix package > is 1.5.0rc1, but it actually wasn't, because there was no tag to say > so.
The tag could be on the same commit that updates guix to 1.5.0rc1, refering to itself. Right now the tag on 2d4ed08662714ea46cfe0b41ca195d1ef845fd1b doesn't seem to be much about the guix tool version per se, does it? >> What purpose does a git tag on 2d4ed08662714ea46cfe0b41ca195d1ef845fd1b >> serve? Is it consumed by anything? Other than the human doing the >> d339785a0fbd8f13930082a4fa7a73b6685630fd commit? > > It's not by human, the guix package is updated by `make > update-guix-package`, also it's used by `make dist` that's done as part > of the release to get the source tarball. This is done on the tagged > commit and autotools will make the name according to the tag, being > 1.5.0rc1. See the `prepare-release` and `release` targets in > Makefile.am. Ah quite so! Then I'm definitely out of my waters about this, and will just leave it as something weird that I'll have to live with. >> If the tag on the first commit really is useful, how about a two-stage >> release process like this: >> >> 1) 'git tag -s -m foo v1.5.0rc1-guix' - similar to the tag on >> 2d4ed08662714ea46cfe0b41ca195d1ef845fd1b. Or make the tag >> namespace-separated as 'guix/v1.5.0rc1'? >> >> 2) Merge the guix update as done in commit >> d339785a0fbd8f13930082a4fa7a73b6685630fd and tag that as 'git tag -s -m >> bar v1.5.0rc1'. > > Sorry I don't really understand this. Still it's not clear what commit > the dist should be made from or why we would say that guix is 1.5.0rc1 > when it's not yet 1.5.0rc1. I think there are two different things of concern here: 1) The version of the Guix 'guix' command-line tool. 2) The version of the Guix git repository including all packaging. I don't think these necessarily have to follow the same version scheme, and the (close) pairing of them is one source for (my) confusion here. /Simon
signature.asc
Description: PGP signature
