On Wednesday, December 7, 2016 8:59:39 AM CET Simon Josefsson wrote: > Den Tue, 06 Dec 2016 17:03:04 +0100 > > skrev Re: libidn2 support: > > On Monday, December 5, 2016 10:00:32 AM CET Simon Josefsson wrote: > > > Hi again. I have added you now. There is no real work going on > > > with libidn2, but Hanno Böck said he may have found more > > > security vulnerabilities, so it would be nice to be able to do a > > > quick security release if needed. Therefor, it appears preferrable > > > to push your stuff to a branch meanwhile. I'm happy to review when > > > it is on a branch, and hopefully we can make test releases from the > > > branch too. > > > > Hi Simon, > > > > just put my stuff into 4 different branches within your Gitlab repo. > > Hi Tim. Yay! > > > Please review/merge in this order: > Very good to split things up, thank you. Let's try to do low-hanging > fruit one at a time. > > > # branch 'fixes' > > - fix two crashes in lookup and register functions > > - avoid tainting insertname/lookupname on error > > Can you write self-tests that trigger these issues? That makes it much > easier to evaluate the patches.
Added a branch 'coverage' based on branch 'libunistring'. It contains a make target 'check-coverage' which runs the test suite with collection coverage stats and generating HTML output in directory 'lcov'. It adds a NFC quick check to avoid unneeded normalizations (explained in http://unicode.org/reports/tr15/#Detecting_Normalization_Forms). I also added a few tests to cover more code paths than before, raising coverage to: lines......: 88.8% (656 of 739 lines) functions..: 95.1% (39 of 41 functions) That was the low hanging fruits, covering more code paths is beyond my time. You could remove the case_flags from punycode_encode() - not used in libidn2. Interestingly, ltr_ends_ok() in bidi.c is never called. That means ltr_lenescsetonbnnsm_ok() always returns false. Not sure what is going on here. Maybe just missing test cases - they added more cases for Unicode > 6.3.0. Regards, Tim
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Help-libidn mailing list Help-libidn@gnu.org https://lists.gnu.org/mailman/listinfo/help-libidn
