Hi, I've run into a problem compiling u-boot with make 3.81 that looks like a change in make's behavior or a broken makefile. We have an implicit rule that works with make 3.80 that changes an elf binary into a .srec file, but make 3.81 errors out:
make[1]: *** No rule to make target `hello_world.srec', needed by `all'. Stop. make[1]: Leaving directory `/home/mort/src/targa/u-boot/u-boot-TOT/examples' make: *** [examples] Error 2 [EMAIL PROTECTED]:~/src/targa/u-boot/u-boot-TOT$ I played around, and switching the implicit rule to a "%.srec : %.o" rule makes it work, as does switching around the order that we specify dependencies. I would rather hear what the problem is, or why the behavior changed between 3.80 and 3.81. u-boot's "examples/Makefile" attached, as are the two patches that I played with that made things work. Fails both 3.81 from gnu.org, and the 3.80+3.81.rc2-1 package that I have from debian testing. Any help appreciated. thanks mh -- Martin Hicks || [EMAIL PROTECTED] || PGP/GnuPG: 0x4C7F2BEE
From nobody Mon Sep 17 00:00:00 2001 From: Martin Hicks <[EMAIL PROTECTED]> Date: Wed Apr 5 18:01:50 2006 -0400 Subject: [PATCH] Switch order of ELF and BIN objects for make 3.81 make 3.81 evaluates things a little differently. Without this patch the build fails as follows with make 3.81 make[1]: *** No rule to make target `hello_world.srec', needed by `all'. Stop. make[1]: Leaving directory `/home/mort/src/targa/u-boot/u-boot-TOT/examples' make: *** [examples] Error 2 Compile tested with make 3.80 and 3.81 Signed-off-by: Martin Hicks <[EMAIL PROTECTED]> --- examples/Makefile | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) fee8cad056b09b76425e027b49144d4e9664662e diff --git a/examples/Makefile b/examples/Makefile index fee2674..5386339 100644 --- a/examples/Makefile +++ b/examples/Makefile @@ -60,44 +60,44 @@ endif include $(TOPDIR)/config.mk SREC = hello_world.srec -BIN = hello_world.bin hello_world +BIN = hello_world hello_world.bin ifeq ($(CPU),mpc8xx) SREC = test_burst.srec -BIN = test_burst.bin test_burst +BIN = test_burst test_burst.bin endif ifeq ($(ARCH),i386) SREC += 82559_eeprom.srec -BIN += 82559_eeprom.bin 82559_eeprom +BIN += 82559_eeprom 82559_eeprom.bin endif ifeq ($(ARCH),ppc) SREC += sched.srec -BIN += sched.bin sched +BIN += sched sched.bin endif ifeq ($(ARCH),blackfin) SREC += smc91111_eeprom.srec -BIN += smc91111_eeprom.bin smc91111_eeprom +BIN += smc91111_eeprom smc91111_eeprom.bin endif # The following example is pretty 8xx specific... ifeq ($(CPU),mpc8xx) SREC += timer.srec -BIN += timer.bin timer +BIN += timer timer.bin endif # The following example is 8260 specific... ifeq ($(CPU),mpc8260) SREC += mem_to_mem_idma2intr.srec -BIN += mem_to_mem_idma2intr.bin mem_to_mem_idma2intr +BIN += mem_to_mem_idma2intr mem_to_mem_idma2intr.bin endif # Utility for resetting i82559 EEPROM ifeq ($(BOARD),oxc) SREC += eepro100_eeprom.srec -BIN += eepro100_eeprom.bin eepro100_eeprom +BIN += eepro100_eeprom eepro100_eeprom.bin endif ifeq ($(BIG_ENDIAN),y) @@ -122,7 +122,7 @@ clibdir := $(shell dirname `$(CC) $(CFLA CPPFLAGS += -I.. -all: .depend $(OBJS) $(LIB) $(SREC) $(BIN) +all: .depend $(OBJS) $(LIB) $(BIN) $(SREC) ######################################################################### $(LIB): .depend $(LIBOBJS) -- 1.2.4
#
# (C) Copyright 2000-2004
# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
#
# See file CREDITS for list of people who contributed to this
# project.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundation; either version 2 of
# the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
# MA 02111-1307 USA
#
ifeq ($(ARCH),ppc)
LOAD_ADDR = 0x40000
endif
ifeq ($(ARCH),i386)
LOAD_ADDR = 0x40000
endif
ifeq ($(ARCH),arm)
LOAD_ADDR = 0xc100000
endif
ifeq ($(ARCH),mips)
LOAD_ADDR = 0x80200000 -T mips.lds
endif
ifeq ($(ARCH),nios)
LOAD_ADDR = 0x00800000 -L $(gcclibdir)/m32 -T nios.lds
endif
ifeq ($(ARCH),nios2)
LOAD_ADDR = 0x00800000 -L $(gcclibdir) -T nios2.lds
endif
ifeq ($(ARCH),m68k)
LOAD_ADDR = 0x20000 -L $(clibdir)
endif
ifeq ($(ARCH),microblaze)
LOAD_ADDR = 0x80F00000
endif
ifeq ($(ARCH),blackfin)
LOAD_ADDR = 0x1000
endif
include $(TOPDIR)/config.mk
SREC = hello_world.srec
BIN = hello_world.bin hello_world
ifeq ($(CPU),mpc8xx)
SREC = test_burst.srec
BIN = test_burst.bin test_burst
endif
ifeq ($(ARCH),i386)
SREC += 82559_eeprom.srec
BIN += 82559_eeprom.bin 82559_eeprom
endif
ifeq ($(ARCH),ppc)
SREC += sched.srec
BIN += sched.bin sched
endif
ifeq ($(ARCH),blackfin)
SREC += smc91111_eeprom.srec
BIN += smc91111_eeprom.bin smc91111_eeprom
endif
# The following example is pretty 8xx specific...
ifeq ($(CPU),mpc8xx)
SREC += timer.srec
BIN += timer.bin timer
endif
# The following example is 8260 specific...
ifeq ($(CPU),mpc8260)
SREC += mem_to_mem_idma2intr.srec
BIN += mem_to_mem_idma2intr.bin mem_to_mem_idma2intr
endif
# Utility for resetting i82559 EEPROM
ifeq ($(BOARD),oxc)
SREC += eepro100_eeprom.srec
BIN += eepro100_eeprom.bin eepro100_eeprom
endif
ifeq ($(BIG_ENDIAN),y)
EX_LDFLAGS += -EB
endif
OBJS = $(SREC:.srec=.o)
LIB = libstubs.a
LIBAOBJS=
ifeq ($(ARCH),ppc)
LIBAOBJS+= $(ARCH)_longjmp.o $(ARCH)_setjmp.o
endif
ifeq ($(CPU),mpc8xx)
LIBAOBJS+= test_burst_lib.o
endif
LIBCOBJS= stubs.o
LIBOBJS = $(LIBAOBJS) $(LIBCOBJS)
gcclibdir := $(shell dirname `$(CC) -print-libgcc-file-name`)
clibdir := $(shell dirname `$(CC) $(CFLAGS) -print-file-name=libc.a`)
CPPFLAGS += -I..
all: .depend $(OBJS) $(LIB) $(SREC) $(BIN)
#########################################################################
$(LIB): .depend $(LIBOBJS)
$(AR) crv $@ $(LIBOBJS)
%: %.o $(LIB)
$(LD) -g $(EX_LDFLAGS) -Ttext $(LOAD_ADDR) \
-o $@ -e $(<:.o=) $< $(LIB) \
-L$(gcclibdir) -lgcc
%.srec: %
$(OBJCOPY) -O srec $< $@ 2>/dev/null
%.bin: %
$(OBJCOPY) -O binary $< $@ 2>/dev/null
#########################################################################
.depend: Makefile $(OBJS:.o=.c) $(LIBCOBJS:.o=.c) $(LIBAOBJS:.o=.S)
$(CC) -M $(CFLAGS) $(OBJS:.o=.c) $(LIBCOBJS:.o=.c)
$(LIBAOBJS:.o=.S) > $@
sinclude .depend
#########################################################################
From nobody Mon Sep 17 00:00:00 2001
From: Martin Hicks <[EMAIL PROTECTED]>
Date: Wed Apr 5 12:02:20 2006 -0400
Subject: [PATCH] objcopy for srec and bin files should be done on .o files
The Makefile rule for creating srec and bin files fails for me frequently.
I believe that we should be doing the ojbcopy on the .o files, not the ELF
binary.
Signed-off-by: Martin Hicks <[EMAIL PROTECTED]>
---
examples/Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
35b9e5c91127f1428c6e207fe2bca76782ca5b36
diff --git a/examples/Makefile b/examples/Makefile
index 2f8c4c4..36fe2a3 100644
--- a/examples/Makefile
+++ b/examples/Makefile
@@ -123,10 +123,10 @@ $(LIB): .depend $(LIBOBJS)
$(LD) -g $(EX_LDFLAGS) -Ttext $(LOAD_ADDR) \
-o $@ -e $(<:.o=) $< $(LIB) \
-L$(gcclibdir) -lgcc
-%.srec: %
+%.srec: %.o
$(OBJCOPY) -O srec $< $@ 2>/dev/null
-%.bin: %
+%.bin: %.o
$(OBJCOPY) -O binary $< $@ 2>/dev/null
#########################################################################
--
1.2.4
signature.asc
Description: Digital signature
_______________________________________________ Help-make mailing list [email protected] http://lists.gnu.org/mailman/listinfo/help-make
