Elrond <[EMAIL PROTECTED]> writes: > On Thu, Mar 23, 2006 at 11:51:38AM +0100, Simon Josefsson wrote: > [...] >> Oops, agreed. >> >> > I don't know, what the right way out of this is. >> > Maybe Shishi_key should know the salt, maybe >> > shishi_key_from_name should output the salt. I don't know, >> > really. >> >> It seems better to separate this, I've created: >> >> int >> shishi_derive_default_salt (Shishi * handle, >> const char *name, >> char **salt) >> >> Which shishi_key_from_name and shisa.c now use. >> >> As a result, shisa.c doesn't use shishi_key_from_name any more, but >> that API may be useful anyway, so I'll keep it. >> >> What do you think? > > Looks mostly good. :) > > shishi_derive_default_salt() should free(principal); > free(realm); at the end. :-)
Fixed, thanks. > shisa.c hasn't yet made it into viewcvs, will look at it > later then. I synced the public cvs now, it should be up to date. /Simon _______________________________________________ Help-shishi mailing list [email protected] http://lists.gnu.org/mailman/listinfo/help-shishi
