On 11/25/2009 10:02 AM, Stefan Izota wrote:
1. PGConnection class >> fieldConverterClass returns PGFieldConverter
class but the file is not in the package.xml.
2. in the definition of PGFieldConverter >> writeQuotedTime, the
variable aDateTime is used; may it should be aTime?
Does the attached patch fix it?
Anyway, how do I make PackageLoader >> fileInPackage to fail if a class
definition is not found?
This is currently not done because some packages have undefined class
references for Squeak compatibility. The right way to do it would be to
wrap the file in with a check that "Undeclared keys" does not change.
It should warn, not fail anyway.
Paolo
diff --git a/packages/dbd-postgresql/FieldConverter.st
b/packages/dbd-postgresql/FieldConverter.st
index ad2c415..fc1d4a8 100644
--- a/packages/dbd-postgresql/FieldConverter.st
+++ b/packages/dbd-postgresql/FieldConverter.st
@@ -57,7 +57,7 @@ FieldConverter subclass: PGFieldConverter [
<category: 'converting-smalltalk'>
"HACK. Time should support timezones too."
(aTime respondsTo: #offset)
- ifTrue: [ self writeDateTime: aDateTime on: aStream ]
+ ifTrue: [ self writeDateTime: aTime on: aStream ]
ifFalse: [ super writeTime: aTime on: aStream ]
]
]
diff --git a/packages/dbd-postgresql/package.xml
b/packages/dbd-postgresql/package.xml
index d9cd2a2..19aa15e 100644
--- a/packages/dbd-postgresql/package.xml
+++ b/packages/dbd-postgresql/package.xml
@@ -10,6 +10,7 @@
<filein>ColumnInfo.st</filein>
<filein>Table.st</filein>
<filein>TableColumnInfo.st</filein>
+ <filein>FieldConverter.st</filein>
<file>Connection.st</file>
<file>ResultSet.st</file>
@@ -17,4 +18,5 @@
<file>ColumnInfo.st</file>
<file>Table.st</file>
<file>TableColumnInfo.st</file>
+ <file>FieldConverter.st</file>
</package>
diff --git a/packages/gtk/GtkImpl.st b/packages/gtk/GtkImpl.st
index 6a2d2fc..6097775 100644
--- a/packages/gtk/GtkImpl.st
+++ b/packages/gtk/GtkImpl.st
@@ -502,7 +502,7 @@ Gtk class extend [
GTK.Gtk main: sem.
sem wait.
- [GTK.Gtk mainIterationDo: false.
+ [GTK.Gtk mainIterationDo: true.
GTK.Gtk shouldQuit]
whileFalse: [Processor yield]
]
_______________________________________________
help-smalltalk mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
