Re: HTML node names: Not emitting 'Top (Manual name)'</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=help-texinfo@gnu.org&q=from:%22pertusus%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">pertusus</span></span></a></span> <span class="date"><a href="/search?l=help-texinfo@gnu.org&q=date:20240316" rel="nofollow">Sat, 16 Mar 2024 07:13:24 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre>On Sat, Mar 16, 2024 at 09:29:59AM +0200, Eli Zaretskii wrote: > > For example, I looked at the mentioned code at > > <a rel="nofollow" href="https://git.savannah.gnu.org/cgit/emacs.git/tree/admin/admin.el">https://git.savannah.gnu.org/cgit/emacs.git/tree/admin/admin.el</a> > > (the manual-html-fix-* functions) and it is not instantly apparent what > > all of the code is supposed to achieve. > > Welcome to the club. The person(s) who wrote that code are no longer > active in Emacs development, so asking them is not an option.</pre><pre> Is there somebody still overseeing that process in term of desired output? > My suggestion is to compare the original HTML files produced by > makeinfo with the massaged files on the GNU Software site, and try > guessing from the diffs what that code is trying to do. My hope is > that any HTML expert (which I am not) will have a good guess by > looking at the diffs (and possibly also at how the results of > processing are shown in a browser, as compared to the original HTML > files produced by makeinfo). I did that. There are some changes that I understand, but some that I don't. I know almost nothing about lisp, but looking at the code and at the output, it seems to me that most of the code does nothing nowadays, or have unintended consequences. It seems actually that this code was mainly targeting Texinfo 5 (and older) makeinfo HTML output but has not really been changed to work with more recent releases. This is visible in constructs that are matched that are, in general, no longer present, although it is unclear whether matching is intended or not. Here are my interrogations. First I have three questions about removed HTML in the that look suspicious to me. I think that it should be checked if this is intended, my wild guess is that it is not: 1) the Copyright notice in comments at the very beginning is removed. 2) the <link href=... rel=... > in <head> are removed, for example <link href="#Top" rel="start" title="top"> <link href="#Starting-Rules" rel="next" title="Starting Rules"> 3) For non split output, the first header/navigation panel is removed. The other main interrogation is about the manual-html-fix-index-1, manual-html-fix-index-2 defun and closing </div> code in manual-html-mono manual-html-node. Most of these codes seems to do nothing nowadays, except for one thing, adding, right after <body ...> an <div id="content" class="inner"> and adding matching </div>. The matching </div> is at the very end of the file for the mono manual, and right before the table of contents in the node split index.html file. It is not clear to me what this div is used for. I had a look at the CSS files, both <a rel="nofollow" href="https://www.gnu.org/software/emacs/manual.css">https://www.gnu.org/software/emacs/manual.css</a> <a rel="nofollow" href="https://www.gnu.org/style.css">https://www.gnu.org/style.css</a> and I did not find a mention of the 'inner' class. The id="content" may still be used to link from other HTML pages to those places in emacs HTML manuals, but I think that this should be checked if this id is really needed, it seems like a bad idea to add an id like that, referring to the file should be better. (If it is still needed, maybe it could be placed on the <body> instead.) My last important interrogation is about CSS. The whole CSS added by texi2any is removed, instead of using the possibility offered by the command-line. My feeling is that what is done right now would be better achieved either by calling with --css-include=/software/emacs/manual.css although it may not lead to the wanted result if there is some disagreement between the CSS output bu texi2any and the emacs CSS. Another possibility would be to add a file named, for example import_emacs_css.css which would only contain @import url('/software/emacs/manual.css'); and use --css-ref=..../import_emacs_css.css at the command-line. I think that it would be better if the texi2any CSS was kept as some is important for some features, such as copiable links. In the CSS file <a rel="nofollow" href="https://www.gnu.org/style.css">https://www.gnu.org/style.css</a> I also noticed that some parts refer to classes no longer used, which is ok if old releases are targeted, but the new class is not there, which makes wonder if some of the code is still needed. Some other remarks, but I would prefer if the issues were not fixed actually ;-). It seems to me that the manual-html-fix-node-div defun does nothing for recent Texinfo releases. I also think that the code in manual-html-node that tries to move Copyright, starting with ;; Move copyright notice to the end. does nothing (though by looking at the code it could have), but I think that it is better that it does nothing, this looks like a bad idea to me. -- Pat </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg03251.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#03253">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#03253">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg03256.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email"><span class="subject"><a href="msg03243.html">Re: HTML <title> node names: Not emitting 'Top (Man...</a></span> <span class="sender italic">Eli Zaretskii</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg03244.html">Re: HTML <title> node names: Not emitting 'Top...</a></span> <span class="sender italic">Gavin Smith</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg03245.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Arsen Arsenović</span></li> <li class="icons-email"><span class="subject"><a href="msg03247.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Eli Zaretskii</span></li> <li class="icons-email"><span class="subject"><a href="msg03255.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Patrice Dumas</span></li> <li class="icons-email"><span class="subject"><a href="msg03265.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Patrice Dumas</span></li> </ul></li> <li class="icons-email"><span class="subject"><a href="msg03246.html">Re: HTML <title> node names: Not emitting 'Top...</a></span> <span class="sender italic">Patrice Dumas</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg03248.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Eli Zaretskii</span></li> <li class="icons-email"><span class="subject"><a href="msg03249.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Gavin Smith</span></li> <li class="icons-email"><span class="subject"><a href="msg03251.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Eli Zaretskii</span></li> <li class="icons-email tSliceCur"><span class="subject">Re: HTML <title> node names: Not emitting ...</span> <span class="sender italic">pertusus</span></li> <li class="icons-email"><span class="subject"><a href="msg03256.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Eli Zaretskii</span></li> <li class="icons-email"><span class="subject"><a href="msg03257.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">pertusus</span></li> <li class="icons-email"><span class="subject"><a href="msg03258.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Eli Zaretskii</span></li> <li class="icons-email"><span class="subject"><a href="msg03259.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">pertusus</span></li> <li class="icons-email"><span class="subject"><a href="msg03264.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Gavin Smith</span></li> <li class="icons-email"><span class="subject"><a href="msg03266.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">pertusus</span></li> <li class="icons-email"><span class="subject"><a href="msg03267.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Gavin Smith</span></li> <li class="icons-email"><span class="subject"><a href="msg03261.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Gavin Smith</span></li> <li class="icons-email"><span class="subject"><a href="msg03260.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">pertusus</span></li> <li class="icons-email"><span class="subject"><a href="msg03262.html">Re: HTML <title> node names: Not emitting ...</a></span> <span class="sender italic">Gavin Smith</span></li> </ul> </ul> </ul> </ul> </ul> </ul> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="Re: HTML <title> node names: Not emitting 'Top (Manual name)'"> <input type="hidden" name="msgid" value="ZfWo8NwduYoCrsO8@free.fr"> <input type="hidden" name="relpath" value="help-texinfo@gnu.org/msg03253.html"> <input type="submit" value=" pertusus "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="help-texinfo@gnu.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search help-texinfo"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/help-texinfo@gnu.org/">help-texinfo - all messages</a></li> <li class="icons-about"><a href="/help-texinfo@gnu.org/info.html">help-texinfo - about the list</a></li> <li class="icons-expand"><a href="/search?l=help-texinfo@gnu.org&q=subject:%22Re%5C%3A+HTML+%3Ctitle%3E+node+names%5C%3A+Not+emitting+%27Top+%5C%28Manual+name%5C%29%27%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg03251.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg03256.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">ZfWo8NwduYoCrsO8@free.fr</li> </ul> </div> </body> </html>