Hi,

I recently fell over a piece of code in the SerializerFactory that looks like 
this

try {
         Class cl = Class.forName(type, false, loader);
         derserializer = getDeserializer(cl);
     } catch (Exception e) {
        log.warning("Hessian/Burlap: '" + type + "' is an unknown class in " + 
loader +":\n" + e);
        log.log(LEVEL.FINER, e.toString(), e);
        }

I am a little puzzeled about this piece of code. So a class cannot be found and 
the code prints out a log and continues as if nothing happens so it'll be only 
harder to find 3 steps later when interpreting the hessian protocol will fail 
with some other exception ?

Who would do something like this ?

Wouldnt it be way better and really the only way to deal with this, to pack the 
Exception into a RuntimeException that you throw ? I think there a more places 
in Hessian where Exceptions are caught and not passed on but this one really 
really bothers me.

What do others think about this ?

thanks

christian campo
-------------------------------------------------------------
compeople AG
Untermainanlage 8
60329 Frankfurt/Main
fon: +49 (0) 69 / 27 22 18 0
fax: +49 (0) 69 / 27 22 18 22
web: http://www.compeople.de/

Vorstand: Jürgen Wiesmaier
Aufsichtsratsvorsitzender: Christian Glanz

Sitz der Gesellschaft: Frankfurt/Main
Handelsregister Frankfurt HRB 56759
Ust-Ident.-Nr: DE207665352
-------------------------------------------------------------



_______________________________________________
hessian-interest mailing list
hessian-interest@caucho.com
http://maillist.caucho.com/mailman/listinfo/hessian-interest

Reply via email to