while I see many developers having only JDK6 these days, after looking at all the requirements you just listed it looks like simpler to keep enforcing 1.5 :)
Regards, Sanne 2010/4/17 Strong Liu <st...@redhat.com>: > Okay, after the discussion with Steve on IRC, here is the update: > > 1. lots of intended contributors only has a JDK6, so with this change can > simplify the process to contribute to hibernate and simple is good :) > 2. there is no known issue/bug that blocks hibernate be built on jdk6. > 3. we must make sure the release build is on jdk5, or the artifacts will not > run on jdk5, this is unacceptable > ( i will working on this to find a way to avoid this happens) > 4. for hibernate commitors, we must make sure the code we check in keep 1.5 > compatibility, and we will explicitly set the java compile target and source > to 1.5( of course for those components that do not need jdk6 jvm) > actually, there is no change for the commitors, you can still do what you're > doing, nothing changed > 5. for hudson job, we need it builds hibernate trunk code on jdk1.5 and run > the tests both on jdk1.5 and jdk6. > Juca, you will help me on this, right? :D > > so, what do you guys think? > > ------------------------- > Best Regards, > > Strong Liu <stliu at redhat.com> > > On Apr 17, 2010, at 10:14 PM, Steve Ebersole wrote: > >> Again, we need *both*. >> >> On Sat, 2010-04-17 at 21:59 +0800, Strong Liu wrote: >>> the difference is with this change, if someone only has jdk6 installed, >>> then it can be used to build hibernate source code instead of installing >>> another jdk. >>> >>> so the question is is there any known issue that causes hibernate >>> components, expect the ones that explicitly ask jdk6, *must* be build on >>> jdk5/4? >>> ------------------------- >>> Best Regards, >>> >>> Strong Liu <stliu at redhat.com> >>> >>> On Apr 17, 2010, at 9:51 PM, Steve Ebersole wrote: >>> >>>> We need both. So really what is the difference? >>>> >>>> On Sat, 2010-04-17 at 12:29 +0800, Strong Liu wrote: >>>>> as that jdbc4 issue has been resolved, so i don't know if there is any >>>>> specific reason that we cant apply this : >>>>> >>>>> Index: parent/pom.xml >>>>> =================================================================== >>>>> --- parent/pom.xml (revision 19221) >>>>> +++ parent/pom.xml (working copy) >>>>> @@ -132,7 +132,7 @@ >>>>> <rules> >>>>> <requireJavaVersion> >>>>> <!-- require JDK 1.5 to run the build --> >>>>> - <version>[1.5,1.6)</version> >>>>> + <version>[1.5,]</version> >>>>> </requireJavaVersion> >>>>> <requireMavenVersion> >>>>> <!-- we need at least Maven 2.0.8 because of a >>>>> bug fix affecting our antlr usage --> >>>>> >>>>> >>>>> >>>>> ------------------------- >>>>> Best Regards, >>>>> >>>>> Strong Liu <stliu at redhat.com> >>>>> >>>>> >>>>> _______________________________________________ >>>>> hibernate-dev mailing list >>>>> hibernate-dev@lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>>> >>>> >>>> -- >>>> Steve Ebersole <st...@hibernate.org> >>>> http://hibernate.org >>>> >>> >> >> >> -- >> Steve Ebersole <st...@hibernate.org> >> http://hibernate.org >> > > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
