yeah, I removed these class in 1a5bdd9adbd04dc4cad7b423e85880d7cb0553ef ( HHH-7736 ) link already added
On Nov 13, 2012, at 5:25 AM, Gail Badner <gbad...@redhat.com> wrote: > I see: HHH-7551 : Remove obsolete code used for dom4j entity mode. > > There are no commits against that Jira though. Strong, was this done using a > different Jira? > > ----- Original Message ----- >> From: "Steve Ebersole" <st...@hibernate.org> >> To: "Gail Badner" <gbad...@redhat.com> >> Cc: "Hibernate hibernate-dev" <hibernate-dev@lists.jboss.org>, "Strong Liu" >> <st...@hibernate.org> >> Sent: Monday, November 12, 2012 7:40:23 AM >> Subject: Re: [hibernate-dev] AssociationType.isEmbeddedInXML() no longer used >> >> Apparently those DOM collection "holders" were already removed on >> metamodel. Can whoever removed them link them back to the >> deprecation? >> >> https://hibernate.onjira.com/browse/HHH-7782 >> >> Thanks >> >> >> On Mon 12 Nov 2012 08:25:23 AM CST, Steve Ebersole wrote: >>> Other things to go away in this same vein: >>> >>> org.hibernate.collection.internal.PersistentIndexedElementHolder >>> org.hibernate.collection.internal.PersistentMapElementHolder >>> >>> I'll deprecate them on master and 4.1 under HHH-7777 >>> >>> On Fri 09 Nov 2012 05:59:58 PM CST, Gail Badner wrote: >>>> Hi Steve, >>>> >>>> I've created the following issues that are assigned to you: >>>> >>>> HHH-7777 : Deprecate XmlRepresentableType >>>> HHH-7776 : Consolidate to/from string handling for types in >>>> StringRepresentableType >>>> >>>> I've added deprecation and removal of EntityType.isNotEmbedded() >>>> to >>>> HHH-7771 and HHH-7772. I'll fix those. >>>> >>>> Regards, >>>> Gail >>>> >>>> ----- Original Message ----- >>>>> From: "Steve Ebersole" <st...@hibernate.org> >>>>> To: "Gail Badner" <gbad...@redhat.com> >>>>> Cc: "Hibernate hibernate-dev" <hibernate-dev@lists.jboss.org>, >>>>> "Strong Liu" <st...@hibernate.org> >>>>> Sent: Thursday, November 8, 2012 7:20:38 PM >>>>> Subject: Re: [hibernate-dev] AssociationType.isEmbeddedInXML() no >>>>> longer used >>>>> >>>>> I was saying to use StringRepresentableType in replacement of >>>>> toXMLString() and fromXMLString(). >>>>> >>>>> Most implementations of these things just delegate amongst >>>>> themselves. >>>>> >>>>> On Thu 08 Nov 2012 08:15:23 PM CST, Gail Badner wrote: >>>>>> I've created HHH-7770 for removing attributes from hbm.xml >>>>>> mapping >>>>>> elements related to EntityMode.DOM4J. Should this be done in >>>>>> metamodel branch for 5.0? Is there any way (or reason) to >>>>>> deprecate these attributes before 5.0? >>>>>> >>>>>> I've also created HHH-7771 for deprecating obsolete Type and >>>>>> AssociationType methods left over from EntityMode.DOM4J. I set >>>>>> the >>>>>> target as 4.1.9. >>>>>> >>>>>> I've created HHH-7772 to remove the deprecated code in 5.0. >>>>>> >>>>>> I'd like to get rid of code having to do with being "embedded in >>>>>> XML" because it is yet another way the word "embedded" is used >>>>>> that adds to confusion. >>>>>> >>>>>> EnhancedUserType and XmlRepresentableType have toXMLString() and >>>>>> fromXMLString(). I am not sure if these are still needed. >>>>>> >>>>>> Steve mentioned something about adding >>>>>> org.hibernate.type.StringRepresentableType to handle basic >>>>>> to/from >>>>>> string handling. I see that StringRepresentableType already has >>>>>> toString() and fromStringValue(). >>>>>> >>>>>> Steve, are you thinking that toXMLString() and fromXMLString() >>>>>> would be added to StringRepresentableType? >>>>>> >>>>>> What about fromString(), toLoggableString()? Would these be >>>>>> added >>>>>> to StringRepresentableType? >>>>>> >>>>>> I don't think this is related to being "embedded in XML", but I >>>>>> noticed there is also EntityType.isNotEmbedded(), which always >>>>>> returns false. AFAICT, it has no impact on anything and can also >>>>>> be deprecated in 4.x and removed in 5.0. Or am I missing >>>>>> something >>>>>> here? >>>>>> >>>>>> Thanks, >>>>>> Gail >>>>>> >>>>>> ----- Original Message ----- >>>>>>> From: "Strong Liu" <st...@hibernate.org> >>>>>>> To: "Gail Badner" <gbad...@redhat.com> >>>>>>> Cc: "Hibernate hibernate-dev" <hibernate-dev@lists.jboss.org> >>>>>>> Sent: Wednesday, October 31, 2012 8:43:56 AM >>>>>>> Subject: Re: [hibernate-dev] AssociationType.isEmbeddedInXML() >>>>>>> no >>>>>>> longer used >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Oct 31, 2012, at 5:54 AM, Gail Badner < gbad...@redhat.com > >>>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> I see that AssociationType.isEmbeddedInXML() is no longer used >>>>>>> anywhere. >>>>>>> >>>>>>> Is this left over from EntityMode.DOM4J? >>>>>>> >>>>>>> >>>>>>> >>>>>>> yes, and I think there is still other methods relate to this >>>>>>> >>>>>>> >>>>>>> >>>>>>> If so, should I go ahead and remove >>>>>>> AssociationType.isEmbeddedInXML() >>>>>>> and its implementation from metamodel branch? >>>>>>> >>>>>>> >>>>>>> >>>>>>> +1 >>>>>>> >>>>>>> >>>>>>> >>>>>>> Regards, >>>>>>> Gail >>>>>>> _______________________________________________ >>>>>>> hibernate-dev mailing list >>>>>>> hibernate-dev@lists.jboss.org >>>>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>>>>>> >>>>>>> >>>>>>> >>>>>>> ------------------------- >>>>>>> Best Regards, >>>>>>> >>>>>>> Strong Liu <stliu at hibernate.org > >>>>>>> http://about.me/stliu/bio >>>>>>> >>>>> >>>>> -- >>>>> st...@hibernate.org >>>>> http://hibernate.org >>>>> >>> >>> -- >>> st...@hibernate.org >>> http://hibernate.org >> >> -- >> st...@hibernate.org >> http://hibernate.org >> ------------------------- Best Regards, Strong Liu <stliu at hibernate.org> http://about.me/stliu/bio _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
