Not sure about the OGM setup, but I think OGM should have its own test utility classes.
Regarding a shared project, imo there is not enough value in such a project, especially since each project will have slightly different requirements. --Hardy On 21 Jan 2013, at 12:14 PM, Davide D'Alto <daltodav...@gmail.com> wrote: > yes, we should fix the call at least for now but I would prefer to create a > a similar class for OGM so that we don't depend from Search for this > operations. > > Is it OK to copy the TestConstants class from OGM to Search? > > Would it make sense to have a separate project for this utility functions? > Every time I write a test in Search or OGM I always end up with the needs > to create a temporary folder. I'm pretty sure there are other methods that > can be useful in different projects. > > > > On Tue, May 21, 2013 at 10:40 AM, Davide D'Alto <daltodav...@gmail.com>wrote: > >> Hello, >> I'll take a look at it and let you know. >> >> Cheers, >> Davide >> >> >> On Mon, May 20, 2013 at 10:05 PM, Guillaume SCHEIBEL < >> guillaume.schei...@gmail.com> wrote: >> >>> There is a second wrong call: >>> >>> AssociationMassIndexerTest.getEntities() >>> >>> >>> 2013/5/20 Guillaume SCHEIBEL <guillaume.schei...@gmail.com> >>> >>>> Hello, >>>> >>>> I've noticed in SimpleEntityMassIndexingTest.getBaseIndexDir() we are >>>> using a method from HSearch: TestConstants.getIndexDirectory(). >>>> >>>> The problem is in OGM this method is used like this: >>>> >>>> *File indexPath = new File( TestConstants.getIndexDirectory(), >>>> shortTestName );* >>>> >>>> but in Hsearch the signature is: >>>> >>>> *public static java.lang.String getIndexDirectory(java.lang.Class<?> >>>> testClass)* >>>> >>>> what should I do ? >>>> I think fixing the call is a good idea. So should rather be ?: >>>> >>>> *File indexPath = new File( TestConstants.getIndexDirectory(** >>>> SimpleEntityMassIndexingTest.class**), shortTestName );* >>>> >>>> Guillaume >>>> >>> _______________________________________________ >>> hibernate-dev mailing list >>> hibernate-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> >> >> > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev