OK, thanks for the info. I am truly trying to rewrite the refactor the testsuite as part of [1] so that we can run the tests against all concurrency strategy modes and cache configurations (I am working on tombstone-based 2LC implementation). Also, I hope I can speed up the testsuite (I see that some tests hang for 15 seconds due to some problem in JGroups).
Radim [1] https://hibernate.atlassian.net/browse/HHH-10030 On 08/14/2015 12:14 PM, Sanne Grinovero wrote: > Context is this IRC question: > > <rvansa> [08:14:33] sannegrinovero: Hi, may I ask why have you > sometimes added InfinispanTestingSetup as @ClassRule and sometimes as > @Rule in HHH-10001? > [11:06] <jbossbot> [08:14:34] jira [HHH-10001] Make the testsuite > compatible with Infinispan 8 [Closed (Fixed) Task, Major, Sanne > Grinovero] https://hibernate.atlassian.net/browse/HHH-10001 > > Hi Radim, > > I generally wanted to set it as test rule only as that gives a > stricter cleanup verification, but in some cases the excessive > isolation rules would have it fail: apparently some are relying on > previous tests. > > That's something which should be cleaned up in the tests I guess but I > only wanted to workaround the API change in the Infinispan testsuite > without risking a semantic change of the tests.. I also didn't have a > good understanding of the purpose of those tests. > > If you're interesting in cleaning that up, you should be able to try > changing the @ClassRule instances to @Rule instances and you'll see > the test fail. > > Sanne -- Radim Vansa <rva...@redhat.com> JBoss Performance Team _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
