On 23 February 2016 at 19:26, Guillaume Smet <guillaume.s...@gmail.com> wrote: > On Tue, Feb 23, 2016 at 7:21 PM, Sanne Grinovero <sa...@hibernate.org> > wrote: >> >> I don't have a strong opinion on the usefulness on faceting on null; >> would someone have a sensible example of faceting on a "null value" ? >> >> We can fix it but I have the impression it's just about fixing a >> developer's itch because of it being inconsistent with other >> components; if it helps with Elasticsearch integration then that makes >> more sense to me. > > > It's not faceting on a null value, it's the ability to support null values > in faceted fields when indexing the entity. Currently, it throws a NPE on > indexing. For instance, you might have entities which doesn't have a value > for a given faceted field. > > Does it make more sense?
Yes! And it explains the next question too. >> But why would you fix it by "if (value == null) return;" ? Do you >> think you can make it work with that? I'd rather actually index the >> marker token defined by 'indexNullAs'. > > Do you think we would want facet results for the indexNullAs value? No, that's what confused me. +1 > >> >> +1 to collect notes on FieldBridge and Document change wishes. > > > OK, will do. > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
