The only consistent way that is going to happen is to set it up on CI On Wed, Feb 14, 2018 at 8:27 AM Sanne Grinovero <sa...@hibernate.org> wrote:
> Thanks for all feedback; I've opened: > - https://hibernate.atlassian.net/browse/HHH-12295 > > Please if you plan to make changes on branch 5.1 could you set > JAVA6_HOME point to an actual JDK6: Animal Sniffer is helpful but it > wil never be as good as testing with the real thing. > > Thanks, > Sanne > > > On 13 February 2018 at 23:06, Gail Badner <gbad...@redhat.com> wrote: > > Hi Sanne, > > > > I didn't notice the failures either. I've been running it with JAVA6_HOME > > pointing to jdk7, but I can't remember why I would have changed it to > that. > > > > It sounds like 5.1 branch will be a product branch for a while, so if > it's > > easy to make it compatible to JDK6, then I'd prefer to do that. > > > > It looks like there are only 2 failures: > > 1) an unused import for import java.util.Objects, which is easily > deleted. > > 2) ReflectHelper#JAVA_CONSTANT_PATTERN uses > > java.util.regex.Pattern.UNICODE_CHARACTER_CLASS. > > > > Vlad, is there some other flag that can be used that is compatible with > > JDK6? If not, is there some other reasonable flag that we can use > instead? > > > > Regards, > > Gail > > > > On Tue, Feb 13, 2018 at 9:24 AM, Sanne Grinovero <sa...@hibernate.org> > > wrote: > >> > >> Is Hibernate ORM 5.1 still meant to be compatible with Java 6? > >> > >> The readme seems to promise that it should be, but it's not: I > >> happened to try compiling it and it failed, as some recent changes are > >> using JDK classes which have been introduced in 7. > >> > >> Turns out it builds fine for Andrea an Chris, as they don't have the > >> JAVA6_HOME variable set: in this case the build will be lenient: log a > >> warning and move on. > >> > >> I guess the same was done by all others on the team? CI is not > >> checking this either. > >> > >> Wondering if you all feel like it's worth fixing branch 5.1, or if > >> it's a dead branch anyway. > >> > >> Thanks, > >> Sanne > >> _______________________________________________ > >> hibernate-dev mailing list > >> hibernate-dev@lists.jboss.org > >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
