FYI,

The tree in CVS doesn't compile:

1) The TransactionManagerLookup interface implements getUserTransactionName().
2) JTATransactionFactory has a bad variable name.


Attached patch fixes these problems.

-Mark

Index: cirrus/hibernate/transaction/JTATransactionFactory.java
===================================================================
RCS file: 
/cvsroot/hibernate/Hibernate/cirrus/hibernate/transaction/JTATransactionFactory.java,v
retrieving revision 1.10
diff -c -r1.10 JTATransactionFactory.java
*** cirrus/hibernate/transaction/JTATransactionFactory.java     10 Dec 2002 13:13:28 
-0000      1.10
--- cirrus/hibernate/transaction/JTATransactionFactory.java     12 Dec 2002 07:54:20 
-0000
***************
*** 58,64 ****
                        try {
                                TransactionManagerLookup tmlookup = 
(TransactionManagerLookup) ReflectHelper.classForName(tmLookupClass).newInstance();
                                transactionManager = 
tmlookup.getTransactionManager(props);
!                               if (utname==null) utname = 
tmlookup.getUserTransactionName();
                                log.info("TransactionManager lookup successful");
                        }
                        catch (HibernateException he) {
--- 58,64 ----
                        try {
                                TransactionManagerLookup tmlookup = 
(TransactionManagerLookup) ReflectHelper.classForName(tmLookupClass).newInstance();
                                transactionManager = 
tmlookup.getTransactionManager(props);
!                               if (utName==null) utName = 
tmlookup.getUserTransactionName();
                                log.info("TransactionManager lookup successful");
                        }
                        catch (HibernateException he) {
Index: cirrus/hibernate/transaction/TransactionManagerLookup.java
===================================================================
RCS file: 
/cvsroot/hibernate/Hibernate/cirrus/hibernate/transaction/TransactionManagerLookup.java,v
retrieving revision 1.3
diff -c -r1.3 TransactionManagerLookup.java
*** cirrus/hibernate/transaction/TransactionManagerLookup.java  8 Dec 2002 05:58:58 
-0000       1.3
--- cirrus/hibernate/transaction/TransactionManagerLookup.java  12 Dec 2002 07:54:20 
-0000
***************
*** 21,28 ****
         * Return the JNDI name of the JTA <tt>UserTransaction</tt>
         * or <tt>null</tt> (optional operation).
         */
!       public String getUserTransactionName() {
!               return null;
!       }
  
  }
--- 21,26 ----
         * Return the JNDI name of the JTA <tt>UserTransaction</tt>
         * or <tt>null</tt> (optional operation).
         */
!       public String getUserTransactionName();
  
  }

Reply via email to