--- Gavin King <[EMAIL PROTECTED]> wrote: > A couple of comments: > > 1. The collection-key tag should not specify a > generator-class unless > you intended it to be toplevel, which I didn't > think was supported > by the XDoclet module and certainly won't be > supported in Hibernate > 2.0. It only really needs to specify a column > attribute.
Current xdoclet stuff is not very intuitive. For example it needs 3 tags to specify bag - hibernate.bag, hibernate.collection-one-to-many & hibernate.collection-key ( and maybe about jca cache ) - "this sux" (c) Burt Simpson :) Though I'm working to make it better, but first I need some more knowlege of hibernate... Toplevel collections are difficult for xdoclet - xdoclet works with source classes, so I'm not sure where they shall be defined. > 2. session.close() should be called in a finally > block. but still wrapped in try-catch - since it throws HIbernateException & SQException :) > 3. strictly, you are supposed to call > session.flush() even after a > save(). In this very simple case you can get away > with it but in > other cases, and when any other style of id > generation than > "native" is used, its needed. Well, already doing this. > Otherwise, this is turning into a very useful demo. Not yet. Updating customer with collection opf addresses does not work, also deleting... Maybe I'm an idiot, or hibernate docs are not complete enough... regards, ===== Konstantin Priblouda ( ko5tik ) Freelance Software developer < http://www.pribluda.de > < play java games -> http://www.yook.de > < render charts online -> http://www.pribluda.de/povray/ > __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ hibernate-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/hibernate-devel
