Oh. Damn. Ummmm .... I have made *very* big changes to exactly that part of the code....
 
Sorry, I don't know....
 
You'll have to look over the code to see how it impacts. You might be lucky though, I imagine the changes will be much simpler now.
 
Gavin
----- Original Message -----
From: Jon Lipsky
Sent: Tuesday, September 24, 2002 11:06 PM
Subject: [Hibernate] Oracle Style Joins Implemented

Hi,
 
I've implemented outer join support for Oracle 8.  (Oracle 9 supports the ANSI style outer joins.)
 
I know Gavin is working on some refactoring right now, so I wanted to make sure my work doesn't interfere with his before I check the patches in.  In order to implement this, I had to modify the following files (along with what I did):
 
Environment.java - Added a "useOracleJoins" environment parameter
 
Loader.java - Added helper methods to generate the additions to the from and the where clause for the Joins
 
CollectionLoader.java - Added check for join type, and then generate ANSI joins or Oracle joins.
 
EntityLoader.java - Added check for join type, and then generate ANSI joins or Oracle joins.
 
OneToManyLoader.java - Added check for join type, and then generate ANSI joins or Oracle joins.
 
 
 
Gavin, if this sounds alright to you, and doesn't conflict with your refactoring, then I will check this in.
 
Thanks,
Jon...
 

Reply via email to