Hum, not keen.
I extensively use the protected and package visibility in the AnnotationBinder. So does Max I think.
If you set the binder in another package, you'll have to set some stuffs public. Plus the Mapping and SecondPass objects will be shared by the cfg package while not being really used by the "usual" users.
I'm not opposed to move the internal classes into a subpackage (cfg.internal), but we'll have cycle dependencies between cfg and its subpackage.
Emmanuel Bernard 01.55.21.52.14 Fnac - DSI Direction France - Nouvelles technologies 67, boulevard du Gal Leclerc 92612 Clichy Cedex
Gavin King wrote:
After Steve merges his branch (next week sometime?), I'd like to refactor the package structure. I'm thinking of the following:
org.hibernate org.hibernate.action org.hibernate.cache org.hibernate.cfg * org.hibernate.cfg.binder (?) org.hibernate.classic org.hibernate.collection org.hibernate.connection org.hibernate.criterion (criteria?) org.hibernate.dialect * org.hibernate.dialect.function org.hibernate.engine org.hibernate.event * org.hibernate.event.default org.hibernate.exception org.hibernate.hql org.hibernate.hql.ast org.hibernate.hql.classic org.hibernate.id org.hibernate.impl org.hibernate.intercept org.hibernate.jca org.hibernate.jdbc org.hibernate.jmx org.hibernate.loader * org.hibernate.loader.entity * org.hibernate.loader.collection * org.hibernate.loader.criteria (?) * org.hibernate.loader.custom org.hibernate.lob org.hibernate.mapping (metamodel?) org.hibernate.metadata * org.hibernate.persister.entity * org.hibernate.persister.collection org.hibernate.pretty org.hibernate.property org.hibernate.proxy org.hibernate.secure org.hibernate.sql org.hibernate.stat org.hibernate.tool.hbm2ddl org.hibernate.tool.instrument org.hibernate.transaction * org.hibernate.transaction.lookup org.hibernate.transform org.hibernate.type org.hibernate.usertype org.hibernate.util
Thats ten (10) new packages! Even harder to navigate in eclipse :-(
Thoughts?
P.S. I considered the idea of always putting implementations of interfaces in an "impl" subpackage of the interface they implement, but I decided it was unnecessarily complex....
------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ hibernate-devel mailing list hibernate-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hibernate-devel
