Re: [Hibernate] Statistics toString()

[Ryan Lynch]

Below is the patch file to add toString() to the stat objects.  Super simple stuff here.

 

Index: src/org/hibernate/stat/CollectionStatistics.java
===================================================================
RCS file: /cvsroot/hibernate/Hibernate3/src/org/hibernate/stat/CollectionStatistics.java,v
retrieving revision 1.5
diff -u -r1.5 CollectionStatistics.java
--- src/org/hibernate/stat/CollectionStatistics.java 8 Aug 2004 10:18:20 -0000 1.5
+++ src/org/hibernate/stat/CollectionStatistics.java 7 Mar 2005 20:08:37 -0000
@@ -28,4 +28,16 @@
  public long getUpdateCount() {
   return updateCount;
  }
+ 
+ public String toString() {
+  return new StringBuffer()
+      .append(super.toString())
+   .append("[loadCount=").append(this.loadCount)
+   .append(",fetchCount=").append(this.fetchCount)
+   .append(",recreateCount=").append(this.recreateCount)
+   .append(",removeCount=").append(this.removeCount)
+   .append(",updateCount=").append(this.updateCount)
+   .append(']')
+   .toString();
+ }
 }
\ No newline at end of file
Index: src/org/hibernate/stat/EntityStatistics.java
===================================================================
RCS file: /cvsroot/hibernate/Hibernate3/src/org/hibernate/stat/EntityStatistics.java,v
retrieving revision 1.5
diff -u -r1.5 EntityStatistics.java
--- src/org/hibernate/stat/EntityStatistics.java 8 Aug 2004 10:18:20 -0000 1.5
+++ src/org/hibernate/stat/EntityStatistics.java 7 Mar 2005 20:08:37 -0000
@@ -29,4 +29,16 @@
  public long getFetchCount() {
   return fetchCount;
  }
+ 
+ public String toString() {
+  return new StringBuffer()
+      .append(super.toString())
+   .append("[loadCount=").append(this.loadCount)
+   .append(",updateCount=").append(this.updateCount)
+   .append(",insertCount=").append(this.insertCount)
+   .append(",deleteCount=").append(this.deleteCount)
+   .append(",fetchCount=").append(this.fetchCount)
+   .append(']')
+   .toString();
+ }
 }
Index: src/org/hibernate/stat/QueryStatistics.java
===================================================================
RCS file: /cvsroot/hibernate/Hibernate3/src/org/hibernate/stat/QueryStatistics.java,v
retrieving revision 1.7
diff -u -r1.7 QueryStatistics.java
--- src/org/hibernate/stat/QueryStatistics.java 22 Dec 2004 22:29:14 -0000 1.7
+++ src/org/hibernate/stat/QueryStatistics.java 7 Mar 2005 20:08:37 -0000
@@ -36,6 +36,7 @@
   return cachePutCount;
  }
  
+ 
  public long getCacheMissCount() {
   return cacheMissCount;
  }
@@ -84,5 +85,20 @@
   executionCount++;
   executionRowCount += rows;
  }
+ 
+ public String toString() {
+  return new StringBuffer()
+      .append(super.toString())
+   .append("[cacheHitCount=").append(this.cacheHitCount)
+   .append(",cacheMissCount=").append(this.cacheMissCount)
+   .append(",cachePutCount=").append(this.cachePutCount)
+   .append(",executionCount=").append(this.executionCount)
+   .append(",executionRowCount=").append(this.executionRowCount)
+   .append(",executionAvgTime=").append(this.executionAvgTime)
+   .append(",executionMaxTime=").append(this.executionMaxTime)
+   .append(",executionMinTime=").append(this.executionMinTime)
+   .append(']')
+   .toString();
+ }
 
 }
Index: src/org/hibernate/stat/SecondLevelCacheStatistics.java
===================================================================
RCS file: /cvsroot/hibernate/Hibernate3/src/org/hibernate/stat/SecondLevelCacheStatistics.java,v
retrieving revision 1.9
diff -u -r1.9 SecondLevelCacheStatistics.java
--- src/org/hibernate/stat/SecondLevelCacheStatistics.java 12 Feb 2005 07:19:46 -0000 1.9
+++ src/org/hibernate/stat/SecondLevelCacheStatistics.java 7 Mar 2005 20:08:37 -0000
@@ -50,4 +50,23 @@
   }
   return map;
  }
+ 
+ public String toString() {
+  StringBuffer buf = new StringBuffer()
+      .append(super.toString())
+   .append("[cache=").append(this.cache.toString())
+   .append(",hitCount=").append(this.hitCount)
+   .append(",missCount=").append(this.missCount)
+   .append(",putCount=").append(this.putCount);
+  //not sure if this would ever be null but wanted to be careful
+  if(th is.cache != null) {
+   buf.append(",ElementCountInMemory=").append(this.getElementCountInMemory())
+    .append(",ElementCountOnDisk=").append(this.getElementCountOnDisk())
+    .append(",SizeInMemory=").append(this.getSizeInMemory());
+  }else{
+   buf.append(",cache=null");
+  }
+  buf.append(']');
+  return buf.toString();
+ }
 }


Max Rydahl Andersen <[EMAIL PROTECTED]> wrote:

On Sat, 05 Mar 2005 02:52:32 +0100, Ryan Lynch <[EMAIL PROTECTED]>wrote:

> I have managed to get the statistics mbean integrated into JBoss but I
> was disappointed that the individual statistics (Entity, Query, etc.)
> objects do not have a meaningful toString() which would allow the user
> to look at the results in the JBoss JMX HttpAdapter. If I submit a
> patch would you guys be interested and could it be integrated fairly
> soon?

patches that adds value are always interesting.
Still, I cant promise when and if the patch will be applied
since it depends on what it actually does ,)


--
Max Rydahl Andersen
callto://max.rydahl.andersen

Hibernate
[EMAIL PROTECTED]
http://hibernate.org

JBoss Inc
[EMAIL PROTECTED]
http://jboss.com


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
hibernate-devel mailing list
hibernate-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/hibernate-devel