On Sun, Aug 29, 2010 at 10:54:29PM +0200, Christof Mroz wrote: > On Sun, 29 Aug 2010 22:33:44 +0200, Diego Biurrun <[email protected]> wrote: > >>> Hum... so reformatting this (A) >>> >>> ctx->transport_hdr.tcp = (struct tcphdr*) >>> (((char *) ip6_hdr) + sizeof(struct ip6_hdr)); >>> >>> to this (B) >>> >>> ctx->transport_hdr.tcp = (struct tcphdr*) >>> (((char *) ip6_hdr) + >>> sizeof(struct ip6_hdr)); >>> >>> rather than this (C) >>> >>> ctx->transport_hdr.tcp = (struct tcphdr*) >>> (((char *) ip6_hdr) + >>> sizeof(struct ip6_hdr)); >>> >>> is recommended even though in (B) the second line is slightly longer >>> than >>> 80 characters (and (A) still looks readable, imho) while in (C) it is >>> within the threshold? >> >> Both (B) and (C) are more readable than (A). Choose your poison. > > I see, maybe HACKING should explicitly state something like "maintaining > vertical alignment is more important than avoiding line breaks"?
Go right ahead and change it... Diego _______________________________________________ Mailing list: https://launchpad.net/~hipl-core Post to : [email protected] Unsubscribe : https://launchpad.net/~hipl-core More help : https://help.launchpad.net/ListHelp
