On Mon, 13 Sep 2010 18:35:34 +0200, Diego Biurrun <[email protected]> wrote:

  Removed superfluous typedef. Some const, cosmetic and doc changes.

This mixes several independent changes.

I actually tried to shelve most of these because they're related imho: Not supposed to alter program logic etc.

Did you do a mechanical substitution and never look at the diff before
committing?

No and no

--- firewall/lsi.c      2010-08-20 14:34:13 +0000
+++ firewall/lsi.c      2010-09-09 00:54:32 +0000
@@ -348,7 +348,8 @@
     if (port_cache_entry &&
         (port_cache_entry->traffic_type ==
-         FIREWALL_PORT_CACHE_IPV6_TRAFFIC)) {
+         FIREWALL_PORT_CACHE_IPV6_TRAFFIC))
+    {

this was correct before

Mhh looked odd because the following code is almost aligned like the clause, but ok.

_______________________________________________
Mailing list: https://launchpad.net/~hipl-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~hipl-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to