Hello Nathalie,
I committed your patch slightly modified because I'd rather have
different behavior in normalizeExternalUri, because it returns "http://"
on an empty string, which doesn't make sense.
I'll commit it in a minute
Ard
>
> Hi,
>
> There's a bug in the bug in the broken link checker. When the
> broken link checker checks on an empty link the broken checker dies.
>
> When the method checkExternalLink(String link) of the class
> BrokenLinkCheckTask gets an extra check this problem will be solved:
>
> just after the first try:
>
> if
> (normalizeExternalUri(link).equals("http://")) {
> Element el = new
> Element("text", "i18n", I18N_NS_URI);
> el.addContent(HTTP_ERROR_PREFIX
> + new Integer(400).toString());
> return el;
> }
>
>
> Maybe there should also be an check on https or another protocol?
>
>
> Regards, Nathalie
> ********************************************
> Hippocms-dev: Hippo CMS development public mailinglist
>
********************************************
Hippocms-dev: Hippo CMS development public mailinglist