Depends on the nature of the issue IMO. This issue was pretty obvious,
and already part of FacetedNavigationAbstractTest.check(....). Keeping
this test was totally redundant and way to trivial, therefor I deleted
it again. But, some tests indeed should be kept after solving the issue
I agree, but it just depends on the issue
Ard
>
> Shouldn't we transform the issue tests to normal tests after
> fixing the issue to prevent regression bugs?
>
> Bart
>
> [EMAIL PROTECTED] wrote:
> >
> > Deleted:
> >
> hippo-ecm/trunk/repository/engine/src/test/java/org/hippoecm/repositor
> > y/HREPTWO321IssueTest.java
> > ===================================================================
> > ---
> hippo-ecm/trunk/repository/engine/src/test/java/org/hippoecm/r
> epository/HREPTWO321IssueTest.java 2007-12-17 09:22:03 UTC
> (rev 9321)
> > +++
> hippo-ecm/trunk/repository/engine/src/test/java/org/hippoecm/r
> epository/HREPTWO321IssueTest.java 2007-12-17 09:22:38 UTC
> (rev 9322)
> > @@ -1,60 +0,0 @@
> > -package org.hippoecm.repository;
> > -
> > -import java.io.IOException;
> > -
> > -import javax.jcr.Node;
> > -import javax.jcr.NodeIterator;
> > -import javax.jcr.PathNotFoundException; -import
> > javax.jcr.RepositoryException;
> > -
> > -import
> > org.hippoecm.repository.FacetedNavigationAbstractTest.Document;
> > -import org.hippoecm.repository.api.HippoNodeType;
> > -
> > -public class HREPTWO321IssueTest extends
> > FacetedNavigationAbstractTest {
> > -
> > - private static final String SYSTEMUSER_ID = "admin";
> > - private static final char[] SYSTEMUSER_PASSWORD =
> "admin".toCharArray();
> > -
> > -
> > - public void testCounts() throws RepositoryException,
> IOException {
> > - numDocs = 500;
> > - commonStart();
> > - check("/navigation/xyz/x1", 1, 0, 0);
> > - commonEnd();
> > - }
> > -
> > - protected void check(String facetPath, int x, int y, int z)
> > - throws RepositoryException {
> > - int realCount = -1;
> > - Node node = session.getRootNode();
> > - if(facetPath.startsWith("/"))
> > - facetPath = facetPath.substring(1); // skip the
> initial slash
> > - String[] pathElements = facetPath.split("/");
> > -
> > - try {
> > - for(int i=0; i<pathElements.length; i++) {
> > - node = node.getNode(pathElements[i]);
> > - }
> > - Node nodeResultSet =
> node.getNode(HippoNodeType.HIPPO_RESULTSET);
> > - NodeIterator iter = nodeResultSet.getNodes();
> > - realCount = 0;
> > - while(iter.hasNext()) {
> > - iter.next();
> > - ++realCount;
> > - }
> > - if(node.hasProperty(HippoNodeType.HIPPO_COUNT)) {
> > - long obtainedCount = (int)
> node.getProperty(HippoNodeType.HIPPO_COUNT).getLong();
> > - if(realCount != obtainedCount){
> > - assertEquals("Issue is NOT resolved" , 1, 1);
> > - } else {
> > - assertEquals("Issue is resolved is
> fails!!" , 1, 2);
> > - }
> > -
> > - }
> > - } catch(PathNotFoundException ex) {
> > - System.err.println("PathNotFoundException:
> "+ex.getMessage());
> > - ex.printStackTrace(System.err);
> > - realCount = 0;
> > - }
> > - }
> > -}
> >
> >
> >
> > _______________________________________________
> > Hippocms-svn mailing list
> > [EMAIL PROTECTED]
> > http://lists.hippo.nl/mailman/listinfo/hippocms-svn
>
>
> --
>
> Hippo
> Oosteinde 11
> 1017WT Amsterdam
> The Netherlands
> Tel +31 (0)20 5224466
> -------------------------------------------------------------
> [EMAIL PROTECTED] / http://www.hippo.nl
> --------------------------------------------------------------
> ********************************************
> Hippocms-dev: Hippo CMS development public mailinglist
>
********************************************
Hippocms-dev: Hippo CMS development public mailinglist
