Nick Stolwijk wrote: > I was looking at the CollectionNotFoundException and thought it was > not really necessary to throw this exception. It would be cleaner if > this would return a DocumentCollection with zero documents. > > What do you think? That would mean something different, would it?
IMO, a CNFE is thrown when the collection doesn't exist at all and an empty collection should/could be returned when the collection does exists and is empty. wdyt? Bart > > Nick Stolwijk > ~Java Developer~ > > Iprofs BV. > Claus Sluterweg 125 > 2012 WS Haarlem > www.iprofs.nl > > > > On Thu, Nov 13, 2008 at 3:14 PM, Nick Stolwijk <[EMAIL PROTECTED]> > wrote: >> Hi, >> >> I was looking at the source of the Hippo Repository Java adapter and >> noticed a few things: >> >> - In the Javadoc of the WebdavService there is no notion of the >> DocumentNotFoundException and CollectionNotFoundException >> - Although it is not explicitly in the Javadoc, it seems that most of >> the methods can not return null. Should this be more explicit? >> - The NOPWebdavService returns null for most of its methods. Something >> which is not possible with the real WebdavServiceImpl. Maybe throw >> exceptions in the NOP implementation? >> - I miss a FacetCollectionNotFoundException for the fetchFacets >> methods. Are those Facets always found or will these methods return >> null when nothing is found? >> >> With regards, >> >> Nick Stolwijk >> ~Java Developer~ >> >> Iprofs BV. >> Claus Sluterweg 125 >> 2012 WS Haarlem >> www.iprofs.nl >> > ******************************************** > Hippocms-dev: Hippo CMS development public mailinglist > > Searchable archives can be found at: > MarkMail: http://hippocms-dev.markmail.org > Nabble: http://www.nabble.com/Hippo-CMS-f26633.html > -- Hippo B.V. - Amsterdam Oosteinde 11, 1017 WT, Amsterdam, +31(0)20-5224466 Hippo USA Inc. - San Francisco 101 H Street, Suite Q, Petaluma CA, 94952-3329, +1 (707) 773-4646 ----------------------------------------------------------------- http://www.onehippo.com - [EMAIL PROTECTED] ----------------------------------------------------------------- ******************************************** Hippocms-dev: Hippo CMS development public mailinglist Searchable archives can be found at: MarkMail: http://hippocms-dev.markmail.org Nabble: http://www.nabble.com/Hippo-CMS-f26633.html
