Canh Ngo pushed to branch feature/cmng-psp1-CHANNELMGR-467 at cms-community /
hippo-addon-channel-manager
Commits:
1b7e7066 by Canh Ngo at 2016-03-16T10:34:30+01:00
CHANNELMGR-467: fixes to follow eslint rules
- - - - -
6 changed files:
- frontend-ng/src/angularjs/channel/catalog.component.directive.js
- frontend-ng/src/angularjs/channel/channel.controller.js
- frontend-ng/src/angularjs/channel/page/element/componentElement.js
- frontend-ng/src/angularjs/channel/page/element/containerElement.js
- frontend-ng/src/angularjs/channel/page/element/pageStructureElement.js
- frontend-ng/src/angularjs/channel/page/pageStructure.service.js
Changes:
=====================================
frontend-ng/src/angularjs/channel/catalog.component.directive.js
=====================================
--- a/frontend-ng/src/angularjs/channel/catalog.component.directive.js
+++ b/frontend-ng/src/angularjs/channel/catalog.component.directive.js
@@ -22,7 +22,7 @@ export function CatalogComponentDirective(CatalogService) {
scope: {
catalogComponent: '=',
},
- link: function (scope, element) {
+ link(scope, element) {
CatalogService.setCatalogElement(scope.catalogComponent, element);
},
};
=====================================
frontend-ng/src/angularjs/channel/channel.controller.js
=====================================
--- a/frontend-ng/src/angularjs/channel/channel.controller.js
+++ b/frontend-ng/src/angularjs/channel/channel.controller.js
@@ -38,14 +38,14 @@ export class ChannelCtrl {
this.addComponentDrake = window.dragula({
ignoreInputTextSelection: false,
- isContainer: function (el) {
+ isContainer(el) {
return el.classList.contains('catalog-dd-container') ||
el.classList.contains('overlay-element-container');
},
copy: true,
- moves: function (el) {
+ moves(el) {
return el.classList.contains('catalog-dd-container-item');
},
- accepts: function (el, target) {
+ accepts(el, target) {
return target.classList.contains('overlay-element-container');
},
});
=====================================
frontend-ng/src/angularjs/channel/page/element/componentElement.js
=====================================
--- a/frontend-ng/src/angularjs/channel/page/element/componentElement.js
+++ b/frontend-ng/src/angularjs/channel/page/element/componentElement.js
@@ -15,6 +15,8 @@
* limitations under the License.
*/
+/* eslint-disable prefer-const */
+
import { PageStructureElement } from './pageStructureElement';
export class ComponentElement extends PageStructureElement {
=====================================
frontend-ng/src/angularjs/channel/page/element/containerElement.js
=====================================
--- a/frontend-ng/src/angularjs/channel/page/element/containerElement.js
+++ b/frontend-ng/src/angularjs/channel/page/element/containerElement.js
@@ -14,6 +14,8 @@
* limitations under the License.
*/
+/* eslint-disable prefer-const */
+
import { HstConstants } from '../../../api/hst.constants';
import { PageStructureElement } from './pageStructureElement';
=====================================
frontend-ng/src/angularjs/channel/page/element/pageStructureElement.js
=====================================
--- a/frontend-ng/src/angularjs/channel/page/element/pageStructureElement.js
+++ b/frontend-ng/src/angularjs/channel/page/element/pageStructureElement.js
@@ -18,7 +18,6 @@ import { HstConstants } from '../../../api/hst.constants';
export class PageStructureElement {
constructor(type, metaData, startCommentDomElement, endCommentDomElement,
boxDomElement) {
-
this.type = type;
this.metaData = metaData;
this.jQueryElements = {};
=====================================
frontend-ng/src/angularjs/channel/page/pageStructure.service.js
=====================================
--- a/frontend-ng/src/angularjs/channel/page/pageStructure.service.js
+++ b/frontend-ng/src/angularjs/channel/page/pageStructure.service.js
@@ -46,7 +46,7 @@ export class PageStructureService {
this.containers.push(new ContainerElement(commentDomElement, metaData,
this.hstCommentsProcessorService));
break;
- case this.HST.TYPE_COMPONENT:
+ case this.HST.TYPE_COMPONENT: {
if (this.containers.length === 0) {
this.$log.warn('Unable to register component outside of a container
context.');
return;
@@ -55,13 +55,14 @@ export class PageStructureService {
const container = this.containers[this.containers.length - 1];
try {
container.addComponent(new ComponentElement(commentDomElement,
metaData,
- container,
this.hstCommentsProcessorService));
+ container, this.hstCommentsProcessorService));
} catch (exception) {
this.$log.debug(exception, metaData);
}
break;
+ }
- case this.HST.TYPE_PAGE:
+ case this.HST.TYPE_PAGE: {
const registeredMetaData = angular.copy(metaData);
delete registeredMetaData[this.HST.TYPE];
this.pageMetaData.add(registeredMetaData);
@@ -73,6 +74,7 @@ export class PageStructureService {
}
}
break;
+ }
default:
break;
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/1b7e70667f087d8fc22a87a80de9746eb5b632c9
_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn
