Tobias Jeger pushed to branch feature/cmng-psp1-CHANNELMGR-497 at cms-community
/ hippo-addon-channel-manager
Commits:
743b11e4 by Tobias Jeger at 2016-03-31T13:56:36+02:00
CHANNELMGR-497: add qa classes for testing.
- - - - -
4 changed files:
- frontend-ng/src/angularjs/channel/channel.controller.js
- frontend-ng/src/angularjs/channel/channel.html
- frontend-ng/src/i18n/hippo-cm.en.json
- frontend-ng/src/i18n/hippo-cm.nl.json
Changes:
=====================================
frontend-ng/src/angularjs/channel/channel.controller.js
=====================================
--- a/frontend-ng/src/angularjs/channel/channel.controller.js
+++ b/frontend-ng/src/angularjs/channel/channel.controller.js
@@ -42,16 +42,19 @@ export class ChannelCtrl {
name: 'desktop',
icon: 'computer',
width: 0,
+ titleKey: 'VIEWPORT_WIDTH_DESKTOP',
},
{
name: 'tablet',
icon: 'tablet',
width: 720,
+ titleKey: 'VIEWPORT_WIDTH_TABLET',
},
{
name: 'phone',
icon: 'smartphone',
width: 320,
+ titleKey: 'VIEWPORT_WIDTH_PHONE',
},
];
=====================================
frontend-ng/src/angularjs/channel/channel.html
=====================================
--- a/frontend-ng/src/angularjs/channel/channel.html
+++ b/frontend-ng/src/angularjs/channel/channel.html
@@ -22,12 +22,12 @@
{{ 'TOOLBAR_BUTTON_COMPONENTS' | translate }}
</md-button>
<span flex></span>
- <md-tabs flex md-no-pagination>
+ <md-tabs flex md-no-pagination class="qa-viewport">
<md-tab ng-repeat="viewPort in channelCtrl.viewPorts"
md-on-select="channelCtrl.selectViewPort(viewPort)"
md-active="channelCtrl.isViewPortSelected(viewPort)">
<md-tab-label>
- <md-icon class="material-icons">{{viewPort.icon}}</md-icon>
+ <md-icon title="{{ viewPort.titleKey | translate }}"
class="material-icons qa-viewport-{{viewPort.name}}">{{viewPort.icon}}</md-icon>
</md-tab-label>
</md-tab>
</md-tabs>
=====================================
frontend-ng/src/i18n/hippo-cm.en.json
=====================================
--- a/frontend-ng/src/i18n/hippo-cm.en.json
+++ b/frontend-ng/src/i18n/hippo-cm.en.json
@@ -13,5 +13,8 @@
"CONFIRM_DISCARD_OWN_CHANGES_MESSAGE": "Are you sure you want to discard all
your unpublished changes to this channel?",
"BUTTON_YES": "Yes",
"BUTTON_NO": "No",
- "ERROR_CREATE_PREVIEW": "Failed to enter Edit mode."
+ "ERROR_CREATE_PREVIEW": "Failed to enter Edit mode.",
+ "VIEWPORT_WIDTH_DESKTOP": "desktop",
+ "VIEWPORT_WIDTH_PHONE": "phone (320px)",
+ "VIEWPORT_WIDTH_TABLET": "tablet (720px)"
}
=====================================
frontend-ng/src/i18n/hippo-cm.nl.json
=====================================
--- a/frontend-ng/src/i18n/hippo-cm.nl.json
+++ b/frontend-ng/src/i18n/hippo-cm.nl.json
@@ -13,5 +13,8 @@
"CONFIRM_DISCARD_OWN_CHANGES_MESSAGE": "Weet u zeker dat u al uw
ongepubliceerde veranderingen in deze channel ongedaan wilt maken?",
"BUTTON_YES": "Ja",
"BUTTON_NO": "Nee",
- "ERROR_CREATE_PREVIEW": "Naar Bewerk modus schakelen heeft gefaald."
+ "ERROR_CREATE_PREVIEW": "Naar Bewerk modus schakelen heeft gefaald.",
+ "VIEWPORT_WIDTH_DESKTOP": "desktop",
+ "VIEWPORT_WIDTH_PHONE": "smartphone (320px)",
+ "VIEWPORT_WIDTH_TABLET": "tablet (720px)"
}
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/743b11e4e4e99d0094f775187de9b5b4d7dbf090
_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn
