Mathijs den Burger pushed to branch feature/visual-editing-psp2-CMS-10706 at
cms-community / hippo-cms
Commits:
43840759 by Mathijs den Burger at 2017-04-25T09:45:07+02:00
CMS-10706 Code improvements (add finals, remove unused constant)
- - - - -
2 changed files:
-
richtext/ckeditor/frontend/src/main/java/org/hippoecm/frontend/plugins/ckeditor/AbstractCKEditorPlugin.java
-
richtext/ckeditor/frontend/src/main/java/org/hippoecm/frontend/plugins/ckeditor/CKEditorPanel.java
Changes:
=====================================
richtext/ckeditor/frontend/src/main/java/org/hippoecm/frontend/plugins/ckeditor/AbstractCKEditorPlugin.java
=====================================
---
a/richtext/ckeditor/frontend/src/main/java/org/hippoecm/frontend/plugins/ckeditor/AbstractCKEditorPlugin.java
+++
b/richtext/ckeditor/frontend/src/main/java/org/hippoecm/frontend/plugins/ckeditor/AbstractCKEditorPlugin.java
@@ -98,7 +98,7 @@ public abstract class AbstractCKEditorPlugin<ModelType>
extends RenderPlugin {
private String createEditorConfiguration(final String defaultJson) {
try {
- IPluginConfig pluginConfig = getPluginConfig();
+ final IPluginConfig pluginConfig = getPluginConfig();
final String overlayedJson =
pluginConfig.getString(CONFIG_CKEDITOR_CONFIG_OVERLAYED_JSON);
final String appendedJson =
pluginConfig.getString(CONFIG_CKEDITOR_CONFIG_APPENDED_JSON);
return CKEditorConfig.combineConfig(defaultJson, overlayedJson,
appendedJson).toString();
=====================================
richtext/ckeditor/frontend/src/main/java/org/hippoecm/frontend/plugins/ckeditor/CKEditorPanel.java
=====================================
---
a/richtext/ckeditor/frontend/src/main/java/org/hippoecm/frontend/plugins/ckeditor/CKEditorPanel.java
+++
b/richtext/ckeditor/frontend/src/main/java/org/hippoecm/frontend/plugins/ckeditor/CKEditorPanel.java
@@ -54,7 +54,6 @@ public class CKEditorPanel extends Panel {
return Collections.singleton(CmsHeaderItem.get());
}
};
- private static final int LOGGED_EDITOR_CONFIG_INDENT_SPACES = 2;
private static final Logger log =
LoggerFactory.getLogger(CKEditorPanel.class);
@@ -114,7 +113,7 @@ public class CKEditorPanel extends Panel {
response.render(OnDomReadyHeaderItem.forScript(getJavaScriptForCKEditorTimestamp()));
response.render(JavaScriptUrlReferenceHeaderItem.forReference(CKEDITOR_PANEL_JS));
- ObjectNode editorConfig = getConfigurationForEditor();
+ final ObjectNode editorConfig = getConfigurationForEditor();
renderContentsCss(response, editorConfig);
response.render(OnDomReadyHeaderItem.forScript(getJavaScriptForEditor(editorConfig)));
}
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-cms/commit/4384075925c19d884e17a6d46c5d4e71af87c0d5
_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn
