Ran Shem Tov pushed to branch bugfix/CHANNELMGR-1429 at cms-community /
hippo-addon-channel-manager
Commits:
bb1f1e61 by Ran ShemTov at 2017-09-18T15:12:17+02:00
CHANNELMGR-1429 Add unit-tests for setters and getters
- - - - -
2 changed files:
- frontend-ng/src/angularjs/channel/channel.controller.spec.js
- frontend-ng/src/angularjs/channel/hippoIframe/hippoIframe.controller.spec.js
Changes:
=====================================
frontend-ng/src/angularjs/channel/channel.controller.spec.js
=====================================
--- a/frontend-ng/src/angularjs/channel/channel.controller.spec.js
+++ b/frontend-ng/src/angularjs/channel/channel.controller.spec.js
@@ -102,6 +102,17 @@ describe('ChannelCtrl', () => {
OverlayService.toggleOverlayByComponent = true;
expect(ChannelCtrl.isComponentsOverlayDisplayed).toEqual(false);
});
+
+ it('setters of isContentOverlayDisplayed & isComponentOverlayDisplayed
should call overlayService functions', () => {
+ spyOn(OverlayService, 'showContentOverlay');
+ spyOn(OverlayService, 'showComponentsOverlay');
+ const arg = false;
+ ChannelCtrl.isContentOverlayDisplayed = arg;
+ ChannelCtrl.isComponentsOverlayDisplayed = arg;
+
+ expect(OverlayService.showContentOverlay).toHaveBeenCalledWith(arg);
+ expect(OverlayService.showComponentsOverlay).toHaveBeenCalledWith(arg);
+ });
});
it('loads the initial page', () => {
=====================================
frontend-ng/src/angularjs/channel/hippoIframe/hippoIframe.controller.spec.js
=====================================
---
a/frontend-ng/src/angularjs/channel/hippoIframe/hippoIframe.controller.spec.js
+++
b/frontend-ng/src/angularjs/channel/hippoIframe/hippoIframe.controller.spec.js
@@ -242,4 +242,11 @@ describe('hippoIframeCtrl', () => {
callback('document-uuid');
expect(scope.onEditContent).toHaveBeenCalledWith('document-uuid');
});
+
+ it('resets overlay toggles', () => {
+ hippoIframeCtrl._resetOverlayToggles();
+
+ expect(hippoIframeCtrl.showComponentsOverlay).toEqual(false);
+ expect(hippoIframeCtrl.showContentOverlay).toEqual(true);
+ });
});
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/bb1f1e6107c74c454fef37029fc4e68fe56e85d8
---
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/bb1f1e6107c74c454fef37029fc4e68fe56e85d8
You're receiving this email because of your account on code.onehippo.org.
_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn
