Hi Owen.

We will be careful about this in future. We have had 3-4 mega drops (including 
the first one, these mega drops actually contain fixes from a whole number of 
people) and part of the reason was that the turn around through hudson and the 
JIRA was too large for us to be able to swiftly deploy the codeand bug fixes 
into production at facebook (yes, we are pretty much running the latest hive 
code in production here). Having said that, we realize the confusion it causes 
and we will be more careful about this.

Ashish

________________________________________
From: Owen O'Malley [EMAIL PROTECTED]
Sent: Thursday, November 13, 2008 2:29 PM
To: [email protected]
Subject: Avoiding mega-patches

Hi all,
    Looking through the Hive jiras, I found HADOOP-4320, which is a
huge jira that seems to have rolled multiple issues into one. I
understand in the rush to get Hive committed, bigger patches were
easier, but they make it very difficult to track what is happening in
the project. Never mind that reviewing a 1.5 mb patch is almost
impossible. It is also very hard for the PMC to know who did what. For
instance, 4320 is assigned to Ashish, but was uploaded by Joydeep.
 From the comments, it seems that they both did parts of the mega-
patch. In the future, please commit the patches for separate issues
separately.

Thanks,
    Owen

Reply via email to