[ 
https://issues.apache.org/jira/browse/HIVE-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654527#action_12654527
 ] 

Raghotham Murthy commented on HIVE-127:
---------------------------------------

+1

Accepting for now.

In general, it seems to be a bad idea to provide a jobconf to the serde. We are 
already passing a Properties object which is arbitrary key-value pairs. If 
there are parameters in the jobconf required by the serde, they should be 
extracted from the jobconf and then inserted into the Properties. This will 
make code flow much more easy to understand. Now, we are passing an opaque 
object (jobconf) with arbitrary key-value pairs which can be set anywhere in 
the code. Can you file another jira to remove jobconf from the SerDe interface?

> fetch task does not pass the job to the serde in initialize
> -----------------------------------------------------------
>
>                 Key: HIVE-127
>                 URL: https://issues.apache.org/jira/browse/HIVE-127
>             Project: Hadoop Hive
>          Issue Type: Bug
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch-127.txt
>
>
> Fetch task passes a null job to the serde during initialize - it should not 
> assume that the serde does not need the job.
> This assumption is valid for MetadataTypedColumnSetSerde, but need not be 
> valid always

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to