[ https://issues.apache.org/jira/browse/HIVE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Thusoo updated HIVE-186: ------------------------------- Attachment: patch-186_2.txt Made the following changes to accommodate the following review comments: 1. Remove new String() from ColumnPriner.java 2. Remove abstract keyword in GraphWalker.java interface 3. Fix tabs in LineageInfo.hava and ColumnPruner.java 4. Javadocs for anon blocks in ParseDriver.java :) 5. Javadocs for moved functions in ColumnPrunerProcCtx.java 6. Separator in RuleRegExp.java 7. Fix operator comments in RuleRegExp.java 8. Test for null in DefaultRuleDispatcher.java As agreed in the review I will be opening JIRAs for cleanups in the old code in DefaultGraphWalker.java and LineageInfo.java. > Refactor code to use a single graph, nodeprocessor, dispatcher and rule > abstraction > ----------------------------------------------------------------------------------- > > Key: HIVE-186 > URL: https://issues.apache.org/jira/browse/HIVE-186 > Project: Hadoop Hive > Issue Type: Improvement > Components: Query Processor > Reporter: Ashish Thusoo > Assignee: Ashish Thusoo > Attachments: patch-186.txt, patch-186_2.txt > > > Currently, the query processor has two different tree and rule abstractions - > one for ASTs and one for Operator Graphs. We should clean this up so that we > have a single abstraction that can be reused at different stages in the query > compiler. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.