[ 
https://issues.apache.org/jira/browse/HIVE-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664641#action_12664641
 ] 

Ashish Thusoo commented on HIVE-25:
-----------------------------------

Comments from the code review with Prasad:

1. Please run the queries also apart from the explain plans in the test cases
2. Union all case should also be added to the tests
3. In SemanticAnalyzer.java:1085 the check for identifier is not needed.
4. getColAliasFromRef does nothing so it can be removed.

Also as we discussed, bigger changes are needed to support:
1. select a.key, a.key from a
2. complex columns are broken in the query because the table alias is optional.

Please file separate JIRAs for those.


> [Hive] cluster by does not work with column aliasing
> ----------------------------------------------------
>
>                 Key: HIVE-25
>                 URL: https://issues.apache.org/jira/browse/HIVE-25
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Prasad Chakka
>            Priority: Critical
>             Fix For: 0.2.0
>
>         Attachments: hive-25-code-changes.patch, hive-25.2.patch, 
> hive-25.patch
>
>
>                     SELECT b.*  
>                     FROM                                                 
>                     (                                                    
>                       SELECT x.col1, x.col2
>                       FROM tmp x              
>                       WHERE x.col2= 10
>                       CLUSTER BY col2                                  
>                     ) b"
> The above query works, but if I change the cluster by to:
> CLUSTER BY x.col2, 
> it croaks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to