[ 
https://issues.apache.org/jira/browse/HIVE-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680621#action_12680621
 ] 

Ashish Thusoo commented on HIVE-192:
------------------------------------

I went through the write up and it looks quite comprehensive from the DDL point 
of view. Here are a few comments:

1. I think we can drop ON UPDATE all together as we do not support UPDATE in 
Hive at this point.
2. auto increment is a nice to have feature since it can be achieved with by 
providing a now() UDF in hive, it is definitely a good feature to have though.
3. Would be great if you could also add the UDFs that could be added to 
timestamps. Mysql has a bunch of these. Some that directly come to mind are 
day(ts), month(ts), year(ts) etc, and to_timestamp function as namit pointed 
out.

As far as storage is concerned, that would depend on the serde in question...


> Cannot create table with timestamp type column
> ----------------------------------------------
>
>                 Key: HIVE-192
>                 URL: https://issues.apache.org/jira/browse/HIVE-192
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.2.0
>            Reporter: Johan Oskarsson
>            Priority: Blocker
>             Fix For: 0.2.0
>
>         Attachments: TIMESTAMP_specification.txt
>
>
> create table something2 (test timestamp);
> ERROR: DDL specifying type timestamp which has not been defined
> java.lang.RuntimeException: specifying type timestamp which has not been 
> defined
>       at 
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.FieldType(thrift_grammar.java:1879)
>       at 
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Field(thrift_grammar.java:1545)
>       at 
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.FieldList(thrift_grammar.java:1501)
>       at 
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Struct(thrift_grammar.java:1171)
>       at 
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.TypeDefinition(thrift_grammar.java:497)
>       at 
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Definition(thrift_grammar.java:439)
>       at 
> org.apache.hadoop.hive.serde2.dynamic_type.thrift_grammar.Start(thrift_grammar.java:101)
>       at 
> org.apache.hadoop.hive.serde2.dynamic_type.DynamicSerDe.initialize(DynamicSerDe.java:97)
>       at 
> org.apache.hadoop.hive.metastore.MetaStoreUtils.getDeserializer(MetaStoreUtils.java:180)
>       at org.apache.hadoop.hive.ql.metadata.Table.initSerDe(Table.java:141)
>       at org.apache.hadoop.hive.ql.metadata.Hive.createTable(Hive.java:202)
>       at org.apache.hadoop.hive.ql.exec.DDLTask.createTable(DDLTask.java:641)
>       at org.apache.hadoop.hive.ql.exec.DDLTask.execute(DDLTask.java:98)
>       at org.apache.hadoop.hive.ql.Driver.run(Driver.java:215)
>       at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:174)
>       at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:207)
>       at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:305)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to