[ 
https://issues.apache.org/jira/browse/HIVE-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681185#action_12681185
 ] 

Raghotham Murthy commented on HIVE-313:
---------------------------------------

We should document the fact that we only do UTC now. Its probably not very 
intuitive to do date arithmetic in UTC if people are thinking in their own 
timezones. I guess we should support locales later (probably another jira).

Also, just checked the date_add spec in the URL specified above. It has a lot 
more functionality than what you have implemented. Similar with date_sub. Maybe 
file jiras to make these functions feature complete?

Btw, if you are confident that we dont have to add tests with table columns, I 
am fine by having only constants.

+1 as long as you file those jiras and add documentation to the Hive Language 
Manual :)

> add UDF date_add, date_sub, datediff
> ------------------------------------
>
>                 Key: HIVE-313
>                 URL: https://issues.apache.org/jira/browse/HIVE-313
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Zheng Shao
>         Attachments: HIVE-313.1.patch, HIVE-313.2.patch
>
>
> See 
> http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_date-add
> See 
> http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_date-sub
> See 
> http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_datediff

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to