[
https://issues.apache.org/jira/browse/HIVE-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682212#action_12682212
]
Joydeep Sen Sarma commented on HIVE-338:
----------------------------------------
some comments:
HiveServer.java:
- where is 'sp' constructed?
- can you encapsulate the 'add'/'delete'/'list' commands in a new processor and
call that from both CliDriver and HiveServer. Even though the logic is trivial
- duplicating code sucks.
- SessionState.java: addToClassPath() - this looks like the same as the one in
ExecDriver.java - can you just make the latter public static and invoke that
- metadata/Hive.java: can you tell why this change was made?
- exec/FunctionTask.java: is it necessary to specify the loader in the
Class.forName call? I thought that that the current thread context loader was
the always the first loader to be tried anyway during name resolution.
- This is missing one change in MapRedTask.java - take a look at the execute()
that generates a command line that executes ExecDriver in a separate jvm (we
use this mode in tests) - here we are setting -libjars option and this needs to
add the ones from the jar resources as well.
- One problem is that this will not work for hadoop-17 (at least local mode) -
see ExecDriver:main() - where addToClassPath is invoked on auxjars as a
workaround for hadoop-17. this would need to be done for other jars added via
'add jar' as well - except there would be no way to do this unless the list of
jar file resources was also passed in as a conf variable.
- Related point - we need a test for this. some dummy udf in a separate jar
file that is added and then invoked from a query would be great (and would have
revealed the above two issues).
- finally - 'delete jar' doesn't seem to get rid of the jar from the classpath.
perhaps this was not required at this time - but would be good to add this just
for sake of completeness. The delete resource codepath is missing a callback
(hook) - that would need to be added as well.
thanks for taking this on - too many small hadoop related complexities here ..
> Executing cli commands into thrift server
> -----------------------------------------
>
> Key: HIVE-338
> URL: https://issues.apache.org/jira/browse/HIVE-338
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Server Infrastructure
> Affects Versions: 0.3.0
> Reporter: Min Zhou
> Attachments: hiveserver-v1.patch
>
>
> Let thrift server support set, add/delete file/jar and normal HSQL query.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
