[ 
https://issues.apache.org/jira/browse/HIVE-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683704#action_12683704
 ] 

Ashish Thusoo commented on HIVE-278:
------------------------------------

Thanks for the explanation.

This looks reasonable and cleaner than before. Taking out the dead code is also 
fine with me. The changes look good except some indentations which seem to be 
out of whack. The logic looks fine to me.


> Add HiveHistory to Hive web interface
> -------------------------------------
>
>                 Key: HIVE-278
>                 URL: https://issues.apache.org/jira/browse/HIVE-278
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Logging, Web UI
>    Affects Versions: 0.3.0
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Minor
>             Fix For: 0.3.0
>
>         Attachments: HIVE-278-1.diff, HIVE-278.diff, hive_history.png, 
> session_logging.diff
>
>
> In order for HIVE-176 to be utilized by the Hive web interface a few changes 
> need to be made.
> * HWISessionItem needs a method with an argument signature 
> {noformat} 
> public HiveHistoryViewer getHistoryViewer() throws HWIException
> {noformat} 
> * session_manage.jsp needs an addition
> {noformat} 
>  Hive History: <a 
> href=/hwi/session_history.jsp?sessionName=<%=sessionName%>"><%=sessionName%></a><br>
> {noformat} 
> * session_history.jsp will have to be created to use the ql.history api

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to