[
https://issues.apache.org/jira/browse/HIVE-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688548#action_12688548
]
Zheng Shao commented on HIVE-337:
---------------------------------
Comments from code review with Ashish, Raghu, and Namit:
1. Move factory methods in LazyUtils to LazyFactory;
2. LazyArray etc should use Factory methods (with TypeInfo as parameter) to
create elements;
3. Comment that LazySimpleSerDe only supports 10 levels of separators currently.
4. Use a global pointer to byte[], and all LazyObjects should point to the
global pointer.
This helps with garbage collection.
5. More Javadoc.
6. Move the 3 fields (bytes, start, length) from LazyNonPrimitive to
LazyObject, add "parsed" to LazyPrimitive.
This makes the code cleaner because all LazyObjects now behave in the same way
- nothing happens in setAll (but cached the values), and actual parsing happens
later.
The trade-off is that LazyPrimitive takes more memory - 12 bytes for bytes,
start, and length.
For 6, a better way would be to always directly parse the data when "setAll" is
called (basically, convert the way LazyNonPrimitive works to the way that
LazyPrimitive works.) The reason is that there is no point of "setAll" if we
don't need to parse the data later, so why don't we directly parse the data in
the "setAll" call?
> LazySimpleSerDe should support array and map types
> --------------------------------------------------
>
> Key: HIVE-337
> URL: https://issues.apache.org/jira/browse/HIVE-337
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Serializers/Deserializers
> Affects Versions: 0.2.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Blocker
> Attachments: HIVE-337.1.patch, HIVE-337.2.patch
>
>
> Once we do that, we can completely deprecate
> DynamicSerDe/TCTLSeparatedProtocol, and close any bugs that
> DynamicSerDe/TCTLSeparatedProtocol has.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.