[
https://issues.apache.org/jira/browse/HIVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688859#action_12688859
]
Namit Jain commented on HIVE-319:
---------------------------------
Looks good - I had some very minor comments:
+ public UDFUnixTimeStamp() {
+ // For now, we just use the default time zone.
+ //formatter.setTimeZone(TimeZone.getTimeZone("UTC"));
+ }
the setting of time zone is commented - it is the default anyway. Can you
remove the code and move the comment where formatter is initialized
FunctionRegistry: Although the actual change is pretty small, the change in the
patch is pretty big - lots of lines added and deleted - probably spacing issue.
Was it intentional ?
If not, can you remove them - just make your changes ? It becomes difficult to
review.
Otherwise, it looks good
> add UDF UNIX_TIMESTAMP
> ----------------------
>
> Key: HIVE-319
> URL: https://issues.apache.org/jira/browse/HIVE-319
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Hao Liu
> Attachments: HIVE-319.2.patch, HIVE-319.patch
>
>
> See
> http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
> For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
