[ 
https://issues.apache.org/jira/browse/HIVE-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714172#action_12714172
 ] 

Zheng Shao commented on HIVE-520:
---------------------------------

I think we should keep the internalInitialize() call in TCTLSeparatedProtocol, 
because people are not required to call initialize (per Thrift TProtocol 
interface).
Otherwise it looks good.

Given the interests of parsing apache logs, I think we will have to keep 
TCTLSeparatedProtocol for some time.


> TestTCTLSeparatedProtocol is broken
> -----------------------------------
>
>                 Key: HIVE-520
>                 URL: https://issues.apache.org/jira/browse/HIVE-520
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>            Priority: Critical
>             Fix For: 0.4.0
>
>         Attachments: HIVE-520.patch
>
>
> Some of the tests in TestTCTLSeparatedProtocol throws a NullPointedException 
> that is catched, logged and not rethrown. This means the tests don't fail 
> even though an unexpected exception is thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to