[ 
https://issues.apache.org/jira/browse/HIVE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716778#action_12716778
 ] 

Zheng Shao commented on HIVE-528:
---------------------------------

Nitpick:
{code}
+      MapJoinObjectCtx ctx = MapJoinOperator.getMapMetadata().get(new 
Integer(metadataTag));
{code}
Use Integer.valueOf() instead since this is going to be called multiple times 
with the same integer number.


Also just to make sure, MapJoinOperator is a singleton so that getMapMetadata() 
can be defined as a static function?
is it possible to have 2 MapJoinOperator in the same mapper? (let's assume 
their join keys are different so they cannot be merged)


> Map Join followup: split MapJoinObject into MapJoinObjectKey and 
> MapJoinObjectValue
> -----------------------------------------------------------------------------------
>
>                 Key: HIVE-528
>                 URL: https://issues.apache.org/jira/browse/HIVE-528
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.4.0
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.528.1.patch
>
>
> split MapJoinObject into MapJoinObjectKey and MapJoinObjectValue for code 
> cleanup

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to