[ 
https://issues.apache.org/jira/browse/HIVE-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723472#action_12723472
 ] 

Joydeep Sen Sarma commented on HIVE-574:
----------------------------------------

- there's a bunch of places where JavaUtils.getClassLoader() is called - all of 
these need to use the conf classloader instead.
- where are we invoking conf.setClassLoader? (addToClassPath should be calling 
this it seems)

if conf.set/getClassLoader is supported in all versions 17 onwards - then we 
can just remove the -libjars business - since that doesn't help us any bit now 
(ExecDriver is not a Tool - so it doesn't even get the conf with the classpath 
set that a Tool would normally get by specifying the -libjars option).

> Hive should use ClassLoader from hadoop Configuration
> -----------------------------------------------------
>
>                 Key: HIVE-574
>                 URL: https://issues.apache.org/jira/browse/HIVE-574
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.3.0, 0.3.1
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-574.1.patch
>
>
> See HIVE-338.
> Hive should always use the getClassByName method from hadoop Configuration, 
> so that we choose the correct ClassLoader. Examples include all plug-in 
> interfaces, including UDF/GenericUDF/UDAF, SerDe, and FileFormats. Basically 
> the following code snippet shows the idea:
> {code}
> package org.apache.hadoop.conf;
> public class Configuration implements Iterable<Map.Entry<String,String>> {
>    ...
>   /**
>    * Load a class by name.
>    * 
>    * @param name the class name.
>    * @return the class object.
>    * @throws ClassNotFoundException if the class is not found.
>    */
>   public Class<?> getClassByName(String name) throws ClassNotFoundException {
>     return Class.forName(name, true, classLoader);
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to