[ 
https://issues.apache.org/jira/browse/HIVE-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732057#action_12732057
 ] 

Namit Jain commented on HIVE-405:
---------------------------------

>> Are you suggesting that we keep initializeChildren() method and override in 
>> MapOperator()?
yes


Yes, MapOperator() becomes more customized, but all other operators become 
simplified
initializeOp() just calls operator specific initialization, if any.
By default, all children are initialized after that, with the 
outputObjectInspector (assuming there is only one).

MapOperator overrides this behavior -- 

If we want to make it more general, we can have an array of 
outputObjectInspectors, one for each child - they will be the same except for 
MapOperator,
but then mapOperator can also fit in this framework - I dont think it is worth 
it to generalize at that level.





> Cleanup operator initialization
> -------------------------------
>
>                 Key: HIVE-405
>                 URL: https://issues.apache.org/jira/browse/HIVE-405
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.4.0
>            Reporter: Zheng Shao
>            Assignee: Prasad Chakka
>            Priority: Critical
>         Attachments: hive-405.6.patch, hive-405.7.patch, hive-405.patch
>
>
> We are always passing the same ObjectInspector, so there is no need to pass 
> it again and again in forward.
> Also there is a problem that can ONLY be fixed by passing ObjectInspector in 
> init: Outer Joins - Outer Joins may not be able to get ObjectInspectors for 
> all inputs, as a result, there is no way to construct an output 
> ObjectInspector based on the inputs. Currently we have hard-coded code that 
> assumes joins are always outputting Strings, which did break but was hidden 
> by the old framework (because we do toString() when serializing the output, 
> and toString() is defined for all Java Classes).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to