[
https://issues.apache.org/jira/browse/HIVE-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760728#action_12760728
]
Ning Zhang commented on HIVE-31:
--------------------------------
Namit's comments:
====
Due to jira connection problems (and losing them twice), sending them by mail.
You can copy in the jira when it is stable:
Looks good - some minor comments.
Tests:
1. Negative: exit at first error, so have a separate file for each case.
2. Positive: Output not deterministic
Add describe also.
ErrorMsg.java:
CTAS_COLLST_COEXISTENCE("Create table as select command cannot specify the
list of columns for the target table."),
CTLT_COLLST_COEXISTENCE("Create table like command cannot specify the list of
columns for the target table."),
Why not ? If it is not supported currently, but you want to add it in a
follow-up, can you file a jira for that ?
SemanticAnalyzerFactory.java:
This affects the ReplicationHook which is used for logging statements.
For CTAS, the output should be the final table which is created - currently, it
is the directory -- needs
to be investigated
SemanticAnalyzer.java:
4370 if ( ! oneLoadFile ) {
4371 // should not have more than
one files to load
4372 throw new
SemanticException(ErrorMsg.CTAS_MULTI_LOADFILE.getMsg());
4373 }
The above error is not really a exception - it can be a assert
Currently, for non CTAS create tables, root tasks are created by
analyzeCreateTable, whereas for CTAS,
it is created later on -- can you file a new jira for this cleanup.
> Hive: support CREATE TABLE xxx SELECT yyy.* FROM yyy
> ----------------------------------------------------
>
> Key: HIVE-31
> URL: https://issues.apache.org/jira/browse/HIVE-31
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Zheng Shao
> Assignee: Ning Zhang
> Attachments: HIVE-31.patch
>
>
> We should allow users to create a table using query result, without
> specifying the column names and column types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
