[ 
https://issues.apache.org/jira/browse/HIVE-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786296#action_12786296
 ] 

Namit Jain commented on HIVE-968:
---------------------------------

Overall looks good, but I had a couple of concerns:

1. 
                                
285             // commit every 100 rows to prevent Out-of-memory exception     
                                
286             if ( (res.size() % 100 == 0) && recman != null ) {              
                        
287             recman.commit();                                        
288             }

Instead of committing every 100 rows in HTree, now we are committing always - 
wont it have a performance issue ?

2. Although we have a new cache on top, but we are loosing the MRU property. It 
should be implemented in the wrapper.


> map join may lead to very large files
> -------------------------------------
>
>                 Key: HIVE-968
>                 URL: https://issues.apache.org/jira/browse/HIVE-968
>             Project: Hadoop Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Ning Zhang
>         Attachments: HIVE-968.patch, HIVE-968_2.patch
>
>
> If the table under consideration is a very large file, it may lead to very 
> large files on the mappers. 
> The job may never complete, and the files will never be cleaned from the tmp 
> directory. 
> It would be great if the table can be placed in the distributed cache, but 
> minimally the following should be added:
> If the table (source) being joined leads to a very big file, it should just 
> throw an error.
> New configuration parameters can be added to limit the number of rows or for 
> the size of the table.
> The mapper should not be tried 4 times, but it should fail immediately.
> I cant think of any better way for the mapper to communicate with the client, 
> but for it to write in some well known
> hdfs file - the client can read the file periodically (while polling), and if 
> sees an error can just kill the job, but with
> appropriate error messages indicating to the client why the job died.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to