[
https://issues.apache.org/jira/browse/HIVE-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786326#action_12786326
]
Namit Jain commented on HIVE-935:
---------------------------------
Very well commented code -
A couple of minor points:
1. The test is not deterministic -
SELECT * FROM src LATERAL VIEW explode(array(1,2,3)) AS myTable LIMIT 3;
-- TABLE.* should be supported
SELECT myTable.* FROM src LATERAL VIEW explode(array(1,2,3)) AS myTable LIMIT 3;
add a order by before the LIMIT
2. In SemanticAnalyzer, whenever you throw an error - add the message in
ErrorMessage.java
3. You can change
private String processLateralView(QB qb, ASTNode lateralView) throws
SemanticException {
int numChildren = lateralView.getChildCount();
if(numChildren != 2) {
throw new SemanticException("Lateral view with incorrect nubmer of
children");
}
to an assert instead
In the same function:
default:
throw new SemanticException("Invalid 3rd child under TOK_LATERAL_VIEW");
}
The error message is not correct
> support LATERAL VIEW
> --------------------
>
> Key: HIVE-935
> URL: https://issues.apache.org/jira/browse/HIVE-935
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Paul Yang
> Attachments: HIVE-935.1.patch, HIVE-935.2.patch, HIVE-935.3.patch,
> HIVE-935.4.patch, HIVE-935.5.patch
>
>
> For table functions, the following syntax should be supported
> select ... from T LATERAL VIEW explode(adid_list) as adid,...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
