[ 
https://issues.apache.org/jira/browse/HIVE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789397#action_12789397
 ] 

Edward Capriolo commented on HIVE-978:
--------------------------------------

Chad,

You are going to have to take into acount the shell scripts in bin, and bin/ext/


{noformat}
# needed for execution
if [ ! -f "${HIVE_LIB}/hive_exec.jar" ]; then
  echo "Missing Hive Execution Jar: ${HIVE_LIB}/hive_exec.jar"
  exit 1;
fi

if [ ! -f "${HIVE_LIB}/hive_metastore.jar" ]; then
  echo "Missing Hive MetaStore Jar"
  exit 2;
fi

# cli specific code
if [ ! -f "${HIVE_LIB}/hive_cli.jar" ]; then
  echo "Missing Hive CLI Jar"
  exit 3;
fi

for f in ${HIVE_LIB}/*.jar; do
  CLASSPATH=${CLASSPATH}:$f;
done
{noformat}

There are no unit tests for this, but they reference file names directly.

Also in the hive-default.conf

{noformat}
<property>
  <name>hive.hwi.war.file</name>
  <value>lib/hive_hwi.war</value>
  <description>path appended to HIVE_HOME to locate the HWI WAR 
file</description>
</property>

{noformat}

> Hive jars should follow Hadoop naming and include version
> ---------------------------------------------------------
>
>                 Key: HIVE-978
>                 URL: https://issues.apache.org/jira/browse/HIVE-978
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Build Infrastructure
>    Affects Versions: 0.5.0
>            Reporter: Chad Metcalf
>            Priority: Minor
>             Fix For: 0.5.0
>
>         Attachments: HIVE-978v1.patch
>
>
> This is a simple patch on the ant build files to change jar naming from
> hive_foo.jar to hive-foo-VERSION.jar
> This matches the convention followed by hadoop jars. This naming scheme is 
> important for packaging, repositories, etc.
> Testing done:
> ant test
> ant tar
> Things look right.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to